From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Steven Cole <elenstev@mesatop.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Juan Quintela <quintela@mandrakesoft.com>,
Russell King <rmk@arm.linux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5 Documentation/CodingStyle ANSI C function declarations.
Date: Mon, 2 Jun 2003 14:34:50 -0300 [thread overview]
Message-ID: <20030602173450.GD9312@conectiva.com.br> (raw)
In-Reply-To: <1054571980.3751.141.camel@spc9.esa.lanl.gov>
Em Mon, Jun 02, 2003 at 10:39:41AM -0600, Steven Cole escreveu:
> On Mon, 2003-06-02 at 09:59, Linus Torvalds wrote:
> > On 2 Jun 2003, Juan Quintela wrote:
> > >
> > > /**
> > > * foo - <put something there>
> > > * @bar: number of frobnicators
> > > * @baz: self-larting on or off
> > > * @userdata: pointer to arbitrary userdata to be registered
> > > *
> > > * Description: Please, fix me
> > > */
> > > int foo(long bar, long baz)
> > > {
> > > ...
> > >
> > > Looks like a better alternative to me.
> >
> > Hey, if somebody were to send me a patch (hint hint), I'd happily apply
> > it.
> >
> > Linus
>
> I sent this last night as an example, except now the function
> declaration is not wrapped. How is this?
>
> Steven
>
> --- linux/lib/zlib_inflate/inftrees.c.orig Mon Jun 2 10:15:29 2003
> +++ linux/lib/zlib_inflate/inftrees.c Mon Jun 2 10:16:47 2003
> @@ -288,14 +288,16 @@
> return y != 0 && g != 1 ? Z_BUF_ERROR : Z_OK;
> +int zlib_inflate_trees_bits(uIntf *c, uIntf *bb, inflate_huft * FAR *tb, inflate_huft *hp, z_streamp z)
> {
> int r;
> uInt hn = 0; /* hufts used in space */
I do it like this:
int zlib_inflate_trees_bits(uIntf *c, uIntf *bb, inflate_huft * FAR *tb,
inflate_huft *hp, z_streamp z)
- Arnaldo
next prev parent reply other threads:[~2003-06-02 17:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-30 19:57 [PATCH] 2.5 Documentation/CodingStyle ANSI C function declarations Steven Cole
2003-05-30 20:14 ` Jörn Engel
2003-05-30 20:25 ` Steven Cole
2003-05-30 20:40 ` Jörn Engel
2003-05-30 20:48 ` Linus Torvalds
2003-05-30 21:20 ` Jörn Engel
2003-05-30 21:38 ` Linus Torvalds
2003-05-30 22:26 ` Jörn Engel
2003-05-30 22:39 ` Davide Libenzi
2003-05-30 22:23 ` Alan Cox
2003-05-30 23:29 ` Davide Libenzi
2003-05-30 22:49 ` Linus Torvalds
2003-05-30 22:55 ` viro
2003-05-30 22:58 ` Jörn Engel
2003-05-30 23:08 ` Riley Williams
2003-05-30 21:06 ` Jörn Engel
2003-05-30 21:09 ` Russell King
2003-05-30 21:17 ` Linus Torvalds
2003-05-31 0:55 ` Steven Cole
2003-05-31 3:12 ` Arnaldo Carvalho de Melo
2003-05-31 5:08 ` Steven Cole
2003-05-31 5:24 ` Michael Frank
2003-05-31 6:27 ` Bernd Eckenfels
2003-05-31 7:17 ` Bernd Eckenfels
2003-06-02 10:53 ` Juan Quintela
2003-06-02 15:59 ` Linus Torvalds
2003-06-02 16:39 ` Steven Cole
2003-06-02 17:34 ` Arnaldo Carvalho de Melo [this message]
2003-06-02 17:55 ` Steven Cole
2003-06-02 17:56 ` Jörn Engel
2003-06-02 16:40 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030602173450.GD9312@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=elenstev@mesatop.com \
--cc=linux-kernel@vger.kernel.org \
--cc=quintela@mandrakesoft.com \
--cc=rmk@arm.linux.org.uk \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox