Re: IDE Power Management (Was: software suspend in 2.5.70-mm3)

[Pavel Machek <pavel@ucw.cz>]

Hi!

> > > Still races. Ben's stuff is needed
> > 
> > I have it working with some fixes from what I sent earlier, I'll
> > repost that tonight or tomorrow, I need to extract that from
> > a half-broken tree ;)
> 
> Ok, here is it. It still need a bit of cleanup (removal of magic
> number for "steps" -> enum, etc...) and we may want to do more
> things on wakeup especially for ide-cd, Also I don't deal with
> ide-tape or ide-floppy in there and haven't fully studied the
> impact with ide-scsi....
> 
> So it's not meant to be merged as-is, though I'd appreciate to
> know if it helps for you.
> 
> Bartolomiej: Any comments appreciated, I won't do the ide-tape/floppy
> part as I don't know/own these, I think i'll let you decide if
> anything more is needed on the wakeup path for ide-cd... Once I
> have enough feedback, I'll send you a cleanified version as
> candidate for upstream merge.

Please send cleaned up version ASAP... Waiting will do no good. If it
handles only ide-disks, that's okay, its still way better than whats
in the tree.

								Pavel
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]