From: Dave Olien <dmo@osdl.org>
To: akpm@digeo.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH} DAC960 fix for fibre channel transfer rate
Date: Wed, 4 Jun 2003 14:32:34 -0700 [thread overview]
Message-ID: <20030604213233.GA15900@osdl.org> (raw)
Andrew, could you push this into 2.5 for me? I got the patch originally
from Michael Griffith <grif@michaelgriffith.com>. I've looked it over
and tested it on the equipment I have. The change makes the transfer
rate numbers come out right for the fibre channel version of this controller.
For 1G FC, the NegotiatedSynchronousMegaTransfers is 1000, and the
NegotiatedDataWidthBIts is 1. The old code assumed NegotiatedDataWidthBits
was always either 8 or 16. The new code is simpler, and does the calculation
correctly for all cases.
Thanks!
Dave Olien
--- linux-2.5.70/drivers/block/DAC960.c Mon May 26 18:00:45 2003
+++ linux-grif/drivers/block/DAC960.c Fri May 30 23:46:23 2003
@@ -2309,8 +2309,7 @@
(PhysicalDeviceInfo->NegotiatedDataWidthBits == 16
? "Wide " :""),
(PhysicalDeviceInfo->NegotiatedSynchronousMegaTransfers
- * (PhysicalDeviceInfo->NegotiatedDataWidthBits == 16
- ? 2 : 1)));
+ * PhysicalDeviceInfo->NegotiatedDataWidthBits/8));
if (InquiryUnitSerialNumber->PeripheralDeviceType != 0x1F)
DAC960_Info(" Serial Number: %s\n", Controller, SerialNumber);
if (PhysicalDeviceInfo->PhysicalDeviceState ==
reply other threads:[~2003-06-04 21:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030604213233.GA15900@osdl.org \
--to=dmo@osdl.org \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox