From: Dave Jones <davej@codemonkey.org.uk>
To: James Morris <jmorris@intercode.com.au>
Cc: pam.delaney@lsil.com, Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] compile fix for MPT Fusion driver for 2.5.70 bk
Date: Thu, 5 Jun 2003 17:29:01 +0100 [thread overview]
Message-ID: <20030605162901.GA7035@suse.de> (raw)
In-Reply-To: <Mutt.LNX.4.44.0306060154230.2735-100000@excalibur.intercode.com.au>
On Fri, Jun 06, 2003 at 02:01:22AM +1000, James Morris wrote:
> The patch below fixes compilation for the MPT Fusion driver, which broke
> with recent changes to the PCI API.
>
> It seems that the code is trying to detect which version of the API its
> being compiled for, but the macro it was looking for has disappeared.
This looks bogus to me.
> diff -urN -X dontdiff bk.pending/drivers/message/fusion/linux_compat.h bk.w1/drivers/message/fusion/linux_compat.h
> --- bk.pending/drivers/message/fusion/linux_compat.h 2003-06-06 00:36:11.000000000 +1000
> +++ bk.w1/drivers/message/fusion/linux_compat.h 2003-06-06 01:48:49.000000000 +1000
> @@ -147,7 +147,7 @@
>
>
> /* PCI/driver subsystem { */
> -#ifndef pci_for_each_dev
> +#ifndef pci_for_each_dev_reverse
> #define pci_for_each_dev(dev) for((dev)=pci_devices; (dev)!=NULL; (dev)=(dev)->next)
What has _reverse got to do with this define ?
Whilst on the subject, how come we still have the _reverse method now
that pci_for_each_dev is dead ?
Dave
next prev parent reply other threads:[~2003-06-05 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-05 16:01 [PATCH] compile fix for MPT Fusion driver for 2.5.70 bk James Morris
2003-06-05 16:29 ` Dave Jones [this message]
2003-06-05 16:33 ` Greg KH
2003-06-05 16:38 ` James Morris
2003-06-07 11:45 ` Adrian Bunk
2003-06-07 16:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030605162901.GA7035@suse.de \
--to=davej@codemonkey.org.uk \
--cc=greg@kroah.com \
--cc=jmorris@intercode.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=pam.delaney@lsil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox