From: Rusty Russell <rusty@rustcorp.com.au>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: linux-kernel@vger.kernel.org
Subject: __check_region in ide code?
Date: Fri, 06 Jun 2003 17:34:24 +1000 [thread overview]
Message-ID: <20030606080454.89EC12C018@lists.samba.org> (raw)
Hi Bart,
I notice that drivers/ide/ide-probe.c's hwif_check_region()
still uses check_region(). If it really does want to use it to probe
and not reserve, I think we should stop it warning there.
There's nothing inherently *wrong* with check_region, it's
just deprecated to trap the old (now racy) idiom of "if
(check_region(xx)) reserve_region(xx)". There's no reason not to
introduce a probe_region if IDE really wants it.
Of course, some people will start "fixing" drivers by
s/check_region/probe_region/ when we do this, but that's the risk we
take.
It should also allow us to easily get rid of that stupid warning in
ksyms.c...
Thoughts?
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next reply other threads:[~2003-06-06 7:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-06 7:34 Rusty Russell [this message]
2003-06-06 8:56 ` __check_region in ide code? Bartlomiej Zolnierkiewicz
2003-06-06 15:23 ` Alan Cox
2003-06-06 16:09 ` Bartlomiej Zolnierkiewicz
2003-06-06 11:31 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030606080454.89EC12C018@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox