From: William Lee Irwin III <wli@holomorphy.com>
To: Jasper Spaans <jasper@vs19.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [TRIVIAL] fix location of zap_low_mappings
Date: Fri, 6 Jun 2003 04:34:43 -0700 [thread overview]
Message-ID: <20030606113443.GD8978@holomorphy.com> (raw)
In-Reply-To: <20030606095749.GA13037@spaans.vs19.net>
On Fri, Jun 06, 2003 at 11:57:49AM +0200, Jasper Spaans wrote:
> When compiling current BK 2.5, I get a warning about zap_low_mappings not
> being declared. Moving it from smp.h to pgtable.h fixes this (and doesn't
> break my setup).
> Does anyone object to this fix?
> [not Cc:-ed to the trivial patch monkey, as I'm not sure whether pgtable.h
> is the right place to put this]
It's basically not supposed to be visible on UP. Perhaps a better
approach would be declare it in pgtable.h as you did, stub out the UP
case with an empty function, and un-#ifdef it from mem_init().
-- wli
next prev parent reply other threads:[~2003-06-06 11:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-06 9:57 [TRIVIAL] fix location of zap_low_mappings Jasper Spaans
2003-06-06 11:34 ` William Lee Irwin III [this message]
2003-06-06 14:33 ` Jasper Spaans
2003-06-06 14:43 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030606113443.GD8978@holomorphy.com \
--to=wli@holomorphy.com \
--cc=jasper@vs19.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox