From: "René Scharfe" <l.s.r@web.de>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org,
trivial@rustcorp.com.au
Subject: Re: [PATCH] hugetlbfs: fix error reporting in case of invalid mount options
Date: Sat, 7 Jun 2003 19:29:27 +0200 [thread overview]
Message-ID: <20030607192927.3d308201.l.s.r@web.de> (raw)
In-Reply-To: <20030607163521.GG8978@holomorphy.com>
On Sat, 7 Jun 2003 09:35:21 -0700 William Lee Irwin III <wli@holomorphy.com> wrote:
> Let's nuke it entirely. All other fs's barf without printk()'ing at all
> and kick -EINVAL back to the caller.
Mmmkay, even better. Patch below.
René
diff -u ./fs/hugetlbfs/inode.c~ ./fs/hugetlbfs/inode.c
--- ./fs/hugetlbfs/inode.c~ 2003-06-07 19:22:27.000000000 +0200
+++ ./fs/hugetlbfs/inode.c 2003-06-07 19:23:03.000000000 +0200
@@ -524,10 +524,9 @@
struct hugetlbfs_config config;
ret = hugetlbfs_parse_options(data, &config);
- if (ret) {
- printk("hugetlbfs: invalid mount options: %s.\n", data);
+ if (ret)
return ret;
- }
+
sb->s_blocksize = PAGE_CACHE_SIZE;
sb->s_blocksize_bits = PAGE_CACHE_SHIFT;
sb->s_magic = HUGETLBFS_MAGIC;
next prev parent reply other threads:[~2003-06-07 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-07 12:55 [PATCH] hugetlbfs: fix error reporting in case of invalid mount options René Scharfe
2003-06-07 16:35 ` William Lee Irwin III
2003-06-07 17:29 ` René Scharfe [this message]
2003-06-07 17:16 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030607192927.3d308201.l.s.r@web.de \
--to=l.s.r@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=trivial@rustcorp.com.au \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox