Re: [PATCH] [3/3] PCI segment support

Matthew Wilcox
2003-06-09T11:04:01Z

On Mon, Jun 09, 2003 at 02:07:49PM +0400, Ivan Kokshaysky wrote:
> Looks good, but shouldn't we pass 'struct pci_bus *' instead
> of pci_dev to pci_domain_nr()?
> Because another place where the domain number must be checked on is
> pci_bus_exists().

hmm, yes, well. There's a certain amount of sloppiness allowed with
it being a macro, in that bus->sysdata and dev->sysdata have the same
value so it works both ways. Of course, this prohibits any architecture
from implementing it as a function, so we really should make up our minds
which it is to be. It sounds like bus is more generally useful than dev,
so I'll make that explicit.

--
"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk