From: Jeff Garzik <jgarzik@pobox.com>
To: Geller Sandor <wildy@petra.hos.u-szeged.hu>
Cc: Daniel Ritz <daniel.ritz@gmx.ch>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] xirc2ps_cs update
Date: Tue, 10 Jun 2003 11:46:55 -0400 [thread overview]
Message-ID: <20030610154655.GA1959@gtf.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0306101731200.10841-100000@petra.hos.u-szeged.hu>
On Tue, Jun 10, 2003 at 05:35:18PM +0200, Geller Sandor wrote:
> On Tue, 10 Jun 2003, Daniel Ritz wrote:
>
> > - busy_loop(HZ/25); /* wait 40 msec */
> > + Wait(HZ/25); /* wait 40 msec */
>
> Why not Wait(40); instead Wait(HZ/25) ? Currently HZ is 1000. However, the
> value can change - as it changed from 100 to 1000.
True enough... the best solution is to grep the tree for a
msecs_to_jiffies macro, and use that. Then it will look like
Wait(msecs_to_jiffies(40))
and the macro does the proper scaling versus constant HZ.
Jeff
next prev parent reply other threads:[~2003-06-10 15:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-10 19:17 [PATCH 1/2] xirc2ps_cs update Daniel Ritz
2003-06-10 19:24 ` [PATCH 2/2] " Daniel Ritz
2003-06-10 15:35 ` Geller Sandor
2003-06-10 15:46 ` Jeff Garzik [this message]
2003-06-10 20:01 ` Daniel Ritz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030610154655.GA1959@gtf.org \
--to=jgarzik@pobox.com \
--cc=daniel.ritz@gmx.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=wildy@petra.hos.u-szeged.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox