Re: [PATCH] loop 2/9 absorb bio_copy

[Jens Axboe <axboe@suse.de>]

On Tue, Jun 10 2003, Hugh Dickins wrote:
> On Tue, 10 Jun 2003, Jens Axboe wrote:
> > On Tue, Jun 10 2003, Hugh Dickins wrote:
> > > bio_copy is used only by the loop driver, which already has to walk the
> > > bio segments itself: so it makes sense to change it from bio.c export
> > > to loop.c static, as prelude to working upon it there.
> > 
> > I don't think this is is a particularly good idea, it's pretty core bio
> > functionality that should be left alone in bio.c imho.
> > 
> > Is there a real reason you want to do this apart from 'loop is the only
> > (current) user'?
> 
> As I said, loop already has to walk the bio segments itself elsewhere,
> and a lot of what bio_copy does (e.g. copying data) it doesn't need done,
> and other things it does (same gfp_mask for two very different allocations)
> don't suit loop very well.  By all means add bio_copy back into fs/bio.c
> when something else needs that functionality?

Alright, I guess I can live with that as there's no direct need for it
elsewhere right now. Just doesn't feel right.

-- 
Jens Axboe