From: Greg KH <greg@kroah.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: BUG in driver model class.c
Date: Wed, 11 Jun 2003 10:18:55 -0700 [thread overview]
Message-ID: <20030611171855.GA25304@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0306111305300.668-100000@ida.rowland.org>
On Wed, Jun 11, 2003 at 01:12:47PM -0400, Alan Stern wrote:
> Greg:
>
> There is a bug in drivers/base/class.c in 2.5.70. Near the start of the
> routine class_device_add() are the lines
>
> if (class_dev->dev)
> get_device(class_dev->dev);
>
> But there's nothing to undo this get_device, either in the error return
> part of class_device_add() or in class_device_del().
>
> I assume that either this get_device() doesn't belong there or else there
> should be corresponding put_device() calls in the other two spots.
> Whichever is the case, it should be easy for you to fix.
Already fixed in Linus's -bk tree :)
thanks for pointing it out though.
greg k-h
next prev parent reply other threads:[~2003-06-11 17:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-11 17:12 BUG in driver model class.c Alan Stern
2003-06-11 17:18 ` Greg KH [this message]
2003-06-11 21:51 ` Greg KH
2003-06-11 21:54 ` Patrick Mochel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030611171855.GA25304@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox