From: Vojtech Pavlik <vojtech@ucw.cz>
To: "Mika Penttilä" <mika.penttila@kolumbus.fi>
Cc: "Bryan O'Sullivan" <bos@serpentine.com>,
ak@suse.de, vojtech@suse.cz, discuss@x86-64.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] New x86_64 time code for 2.5.70
Date: Thu, 12 Jun 2003 08:47:26 +0200 [thread overview]
Message-ID: <20030612084726.D12126@ucw.cz> (raw)
In-Reply-To: <3EE79FD1.8060503@kolumbus.fi>; from mika.penttila@kolumbus.fi on Thu, Jun 12, 2003 at 12:32:01AM +0300
On Thu, Jun 12, 2003 at 12:32:01AM +0300, Mika Penttilä wrote:
> /*
> + * Read the period, compute tick and quotient.
> + */
> +
> + id = hpet_readl(HPET_ID);
> +
> + if (!(id & HPET_ID_VENDOR) || !(id & HPET_ID_NUMBER) ||
> + !(id & HPET_ID_LEGSUP))
> + return -1;
> +
> + hpet_period = hpet_readl(HPET_PERIOD);
> + if (hpet_period < 100000 || hpet_period > 100000000)
> + return -1;
> +
>
>
> Line below seems to be wrong, given hpet period is in fsecs.
>
>
> + hpet_tick = (tick_nsec + hpet_period / 2) / hpet_period;
Yes, it should be:
hpet_tick = (1000000000L * (USECS_PER_SEC/HZ) + hpet_period / 2) / hpet_period;
>
>
>
>
>
> --Mika
>
>
>
>
>
--
Vojtech Pavlik
SuSE Labs, SuSE CR
prev parent reply other threads:[~2003-06-12 6:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-11 18:50 [PATCH] New x86_64 time code for 2.5.70 Bryan O'Sullivan
2003-06-11 19:18 ` Andi Kleen
2003-06-11 19:56 ` Bryan O'Sullivan
2003-06-11 20:10 ` Bryan O'Sullivan
2003-06-11 21:23 ` john stultz
2003-06-11 21:36 ` Bryan O'Sullivan
2003-06-11 21:41 ` john stultz
2003-06-12 0:33 ` john stultz
2003-06-12 6:40 ` Vojtech Pavlik
2003-06-12 17:47 ` Bryan O'Sullivan
2003-06-12 19:39 ` john stultz
2003-06-12 19:55 ` Vojtech Pavlik
2003-06-12 21:16 ` Bryan O'Sullivan
2003-06-13 1:43 ` john stultz
2003-06-12 19:48 ` Vojtech Pavlik
2003-06-11 20:41 ` Vojtech Pavlik
2003-06-11 20:44 ` john stultz
2003-06-11 21:32 ` Mika Penttilä
2003-06-11 21:28 ` Bryan O'Sullivan
2003-06-12 4:40 ` [discuss] " Andreas Jaeger
2003-06-12 6:42 ` Vojtech Pavlik
2003-06-12 6:47 ` Vojtech Pavlik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030612084726.D12126@ucw.cz \
--to=vojtech@ucw.cz \
--cc=ak@suse.de \
--cc=bos@serpentine.com \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.penttila@kolumbus.fi \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox