From: Maneesh Soni <maneesh@in.ibm.com>
To: Andrew Morton <akpm@digeo.com>
Cc: LKML <linux-kernel@vger.kernel.org>, trond.myklebust@fys.uio.no
Subject: [patch] LIST_POISON with rcu
Date: Thu, 12 Jun 2003 15:31:26 +0530 [thread overview]
Message-ID: <20030612100126.GA1212@in.ibm.com> (raw)
Hi,
LIST_POISON will not work with RCU based lists as we depend on the
fact the deleted list element can still point to the existing list.
Though any new user will not be able to reach the deleted element.
This is one of the reasons why we don't do list_del_init_rcu().
The folloing patch fixes this.
Trond, I am not sure if you are seeing the d_move() oops because
of this. It will be nice if you can post the oops message also.
Regards,
Maneesh
diff -urN linux-2.5.70-mm8/include/linux/list.h linux-2.5.70-mm8-LIST_POISON/include/linux/list.h
--- linux-2.5.70-mm8/include/linux/list.h Thu Jun 12 15:26:06 2003
+++ linux-2.5.70-mm8-LIST_POISON/include/linux/list.h Thu Jun 12 15:24:51 2003
@@ -162,8 +162,6 @@
static inline void list_del_rcu(struct list_head *entry)
{
__list_del(entry->prev, entry->next);
- entry->next = LIST_POISON1;
- entry->prev = LIST_POISON2;
}
/**
@@ -434,7 +432,10 @@
n->pprev = LIST_POISON2;
}
-#define hlist_del_rcu hlist_del /* list_del_rcu is identical too? */
+static __inline__ void hlist_del_rcu(struct hlist_node *n)
+{
+ __hlist_del(n);
+}
static __inline__ void hlist_del_init(struct hlist_node *n)
{
--
Maneesh Soni
IBM Linux Technology Center,
IBM India Software Lab, Bangalore.
Phone: +91-80-5044999 email: maneesh@in.ibm.com
http://lse.sourceforge.net/
next reply other threads:[~2003-06-12 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-12 10:01 Maneesh Soni [this message]
2003-06-12 15:15 ` [patch] LIST_POISON with rcu Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030612100126.GA1212@in.ibm.com \
--to=maneesh@in.ibm.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox