Re: 2.5.70-mm8

Thomas Schlichter
2003-06-11T09:18:16Z

[-- Attachment #1.1: Type: text/plain, Size: 602 bytes --]

Hi!

Stefano Rivoir wrote:
> Andrew Morton wrote:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.70/2.5.
> >70-mm8/
>
> arch/i386/kernel/setup.c: In function 'setup_early_printk':
> arch/i386/kernel/setup.c:919: error: invalid lvalue in unary '&'
> make[1]: *** [arch/i386/kernel/setup.o] Error 1
>
> Bye

I had the same problem, it occours when the kernel is compiled without SMP
support and EARLY_PRINTK is not explicitly disabled in the 'Kernel hacking'
config-section.

The attached patch helps me with this error...

Best regards
Thomas Schlichter

[-- Attachment #1.2: early_printk_fix.diff --]
[-- Type: text/x-diff, Size: 660 bytes --]

--- linux-2.5.70-mm8/arch/i386/kernel/setup.c.orig Wed Jun 11 11:10:35 2003
+++ linux-2.5.70-mm8/arch/i386/kernel/setup.c Wed Jun 11 11:11:36 2003
@@ -910,6 +910,7 @@
extern int __init serial8250_console_init(void);
void setup_early_printk(void)
{
+#ifdef CONFIG_SMP
/*
* printk currently checks cpu_online_map to make sure that
* we don't try to printk from a CPU which hasn't had resources
@@ -917,6 +918,7 @@
* enable here don't require per-cpu resources.
*/
set_bit(smp_processor_id(), &cpu_online_map);
+#endif
#ifdef CONFIG_DEBUG_EP_SERIAL
console_setup(CONFIG_DEBUG_SERIAL_OPTIONS);
serial8250_console_init();

[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]