Re: [PATCH] udev enhancements to use kernel event queue

Robert Love
2003-06-12T23:17:00Z

On Thu, 2003-06-12 at 16:25, Patrick Mochel wrote:

> Yeah, how about this ammended patch?

Both this and Greg's look fine.

I guess this is preferred, since the lock hold time is shorter :)

> + spin_lock(&sequence_lock);
> + seq = sequence_num++;
> + spin_unlock(&sequence_lock);
> +
> + envp [i++] = scratch;
> + scratch += sprintf(scratch, "SEQNUM=%ld", seq) + 1;

Nice thinking. It is a shame we need a lock for this, but we don't have
an atomic_inc_and_return().

Robert Love