Re: [PATCH] udev enhancements to use kernel event queue

Greg KH
2003-06-18T23:16:51Z

On Fri, Jun 13, 2003 at 10:01:47PM +0200, Oliver Neukum wrote:
>
> > +
> > + spin_lock(&sequence_lock);
> > + envp [i++] = scratch;
> > + scratch += sprintf(scratch, "SEQNUM=%ld", sequence_num) + 1;
> > + ++sequence_num;
> > + spin_unlock(&sequence_lock);
> >
> > kobj_path_length = get_kobj_path_length (kset, kobj);
> > kobj_path = kmalloc (kobj_path_length, GFP_KERNEL);
>
> If this kmalloc fails, you'll have a hole in the numbers and
> user space will be very confused. You need to report dropped
> events if you do this.

Yes, we should add the sequence number last.

Good catch.

greg k-h