Re: [PATCH] Logitech PS/2++ updates

Vojtech Pavlik
2003-06-14T22:46:02Z

On Tue, Mar 25, 2003 at 06:55:38PM -0800, Eric Wong wrote:

> Updates to the PS/2++ mouse protocol used by Logitech, as well as
> SMS/Smart Scroll/Cruise Control and 800 cpi resolution control for those
> who want it. Up to 10 buttons are supported now, although only 8 are
> used at the moment on the MX500 and MX700.

Nice.

> /*
> * The PS2++ protocol is a little bit complex
> */
> + if (psmouse->type == PSMOUSE_PS2PP) {
> +
> + if ((packet[0] & 0x48) == 0x48 && (packet[1] & 0x02) == 0x02 ) {
>

Hmm, is this change needed? This

if ((packet[0] & 0x40) == 0x40 && abs((int)packet[1] - (((int)packet[0] & 0x10) << 4)) > 191 ) {

condition is from Logitech docs and should work with any PS2PP device.
It doesn't with yours?