From: Vojtech Pavlik <vojtech@suse.cz>
To: Eric Wong <eric@yhbt.net>
Cc: linux-kernel@vger.kernel.org, linus@transmeta.com, vojtech@suse.cz
Subject: Re: [PATCH] Logitech PS/2++ updates
Date: Sun, 15 Jun 2003 00:59:47 +0200 [thread overview]
Message-ID: <20030615005947.E27599@ucw.cz> (raw)
In-Reply-To: <20030326025538.GB12549@BL4ST>; from eric@yhbt.net on Tue, Mar 25, 2003 at 06:55:38PM -0800
On Tue, Mar 25, 2003 at 06:55:38PM -0800, Eric Wong wrote:
> Updates to the PS/2++ mouse protocol used by Logitech, as well as
> SMS/Smart Scroll/Cruise Control and 800 cpi resolution control for those
> who want it. Up to 10 buttons are supported now, although only 8 are
> used at the moment on the MX500 and MX700.
Nice.
> /*
> * The PS2++ protocol is a little bit complex
> */
> + if (psmouse->type == PSMOUSE_PS2PP) {
> +
> + if ((packet[0] & 0x48) == 0x48 && (packet[1] & 0x02) == 0x02 ) {
>
Hmm, is this change needed? This
if ((packet[0] & 0x40) == 0x40 && abs((int)packet[1] - (((int)packet[0] & 0x10) << 4)) > 191 ) {
condition is from Logitech docs and should work with any PS2PP device.
It doesn't with yours?
--
Vojtech Pavlik
SuSE Labs, SuSE CR
next prev parent reply other threads:[~2003-06-14 22:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-26 2:55 [PATCH] Logitech PS/2++ updates Eric Wong
2003-06-14 21:18 ` Vojtech Pavlik
2003-06-14 23:39 ` Eric Wong
2003-06-15 8:39 ` Vojtech Pavlik
2003-06-17 23:16 ` Eric Wong
2003-06-20 7:34 ` Vojtech Pavlik
2003-06-14 22:59 ` Vojtech Pavlik [this message]
2003-06-15 0:29 ` Eric Wong
2003-06-15 7:21 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030615005947.E27599@ucw.cz \
--to=vojtech@suse.cz \
--cc=eric@yhbt.net \
--cc=linus@transmeta.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox