From: Christoph Hellwig <hch@infradead.org>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] make cramfs look less hostile
Date: Sun, 15 Jun 2003 18:44:17 +0100 [thread overview]
Message-ID: <20030615184417.A19712@infradead.org> (raw)
In-Reply-To: <20030615173926.GH1063@wohnheim.fh-wedel.de>; from joern@wohnheim.fh-wedel.de on Sun, Jun 15, 2003 at 07:39:26PM +0200
On Sun, Jun 15, 2003 at 07:39:26PM +0200, Jörn Engel wrote:
> > Umm, cramfs_fill_super has a silent parameter that's true for
> > probing the root filesystem. I'd suggest disabling the printk
> > completly if it's set.
>
> Good idea, but only at first glance. cramfs_fill_super() always gets
> called with silent=1. So if "(!silent) printk(...);" is functionally
> equivalent to ";".
It's not. The rootfs is mounted with the (grossly misnamed) MS_VERBOSE
flag which translates to the last argument of the fill_super callback
set to 1.
next prev parent reply other threads:[~2003-06-15 17:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-15 16:05 [PATCH] make cramfs look less hostile Jörn Engel
[not found] ` <Pine.LNX.4.44.0306151245070.29663-100000@coffee.psychology.mcmaster.ca>
2003-06-15 17:17 ` Jörn Engel
[not found] ` <200306151157.10493.brian@mdrx.com>
2003-06-15 17:19 ` Jörn Engel
2003-06-15 17:26 ` Christoph Hellwig
2003-06-15 17:39 ` Jörn Engel
2003-06-15 17:44 ` Christoph Hellwig [this message]
2003-06-15 17:58 ` Jörn Engel
2003-06-15 18:03 ` Christoph Hellwig
2003-06-15 18:14 ` Jörn Engel
2003-06-15 18:18 ` Christoph Hellwig
2003-06-15 21:49 ` Andries Brouwer
2003-06-16 9:12 ` Jörn Engel
2003-06-16 11:21 ` Andries Brouwer
2003-06-16 11:37 ` Jörn Engel
2003-06-18 0:24 ` Robert White
2003-06-15 17:27 ` Jörn Engel
2003-06-16 5:54 ` H. Peter Anvin
[not found] <20030615161009$6dde@gated-at.bofh.it>
[not found] ` <20030615174004$76d0@gated-at.bofh.it>
[not found] ` <20030615175007$7f59@gated-at.bofh.it>
[not found] ` <20030615175012$0573@gated-at.bofh.it>
[not found] ` <20030615181004$3663@gated-at.bofh.it>
[not found] ` <20030615181010$7f10@gated-at.bofh.it>
[not found] ` <20030615182013$7a4e@gated-at.bofh.it>
[not found] ` <20030615183011$3fc0@gated-at.bofh.it>
2003-06-15 21:20 ` Pascal Schmidt
2003-06-16 5:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030615184417.A19712@infradead.org \
--to=hch@infradead.org \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox