From: Roman Kagan <Roman.Kagan@itep.ru>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] use tty_driver.name as default .devfs_name
Date: Mon, 16 Jun 2003 00:02:30 +0400 [thread overview]
Message-ID: <20030615200230.GA22240@panda.itep.ru> (raw)
Hi,
In 2.5.71 with devfs enabled my USB modem appears as /dev/<NULL>0
instead of the usual /dev/usb/acm/0. I tracked down this problem to be
due to
ChangeSet@1.1215.98.11 2003-06-06 08:54:35-07:00 akpm@digeo.com
(originally "[PATCH] Fix tty devfs mess" from Christoph Hellwig
<hch@lst.de>)
where a new .devfs_name field was introduced in struct tty_driver.
However, many drivers (including cdc-acm) haven't been updated to define
it. OTOH they seem to be quite happy using their .name for devfs as
well. This patch makes .name the default .devfs_name. Since
tty_{,un}register_device() appear to be the only users of .devfs_name,
there should be no side effects. WFM. Please consider applying.
Roman.
--- linux-2.5.71/drivers/char/tty_io.c~ 2003-06-14 23:18:23.000000000 +0400
+++ linux-2.5.71/drivers/char/tty_io.c 2003-06-15 22:20:51.000000000 +0400
@@ -2183,6 +2183,10 @@
return;
}
+ /* Use driver name for devfs as well */
+ if (!driver->devfs_name)
+ driver->devfs_name = driver->name;
+
devfs_mk_cdev(dev, S_IFCHR | S_IRUSR | S_IWUSR,
"%s%d", driver->devfs_name, index + driver->name_base);
reply other threads:[~2003-06-15 19:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030615200230.GA22240@panda.itep.ru \
--to=roman.kagan@itep.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox