From: Stelian Pop <stelian@popies.net>
To: Michael Buesch <fsdeveloper@yahoo.de>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.4.21] meye driver update
Date: Sun, 15 Jun 2003 23:29:35 +0200 [thread overview]
Message-ID: <20030615212935.GA1582@deep-space-9.dsnet> (raw)
In-Reply-To: <200306151906.57099.fsdeveloper@yahoo.de>
On Sun, Jun 15, 2003 at 07:06:56PM +0200, Michael Buesch wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Sunday 15 June 2003 18:31, Stelian Pop wrote:
> > Hi,
>
> Hi Stelian,
>
> > +void dma_free_coherent(struct pci_dev *dev, size_t size,
> ^^^^^^^^^^^^^^^^^^^
> > + void *vaddr, dma_addr_t dma_handle)
> ^^^^^^^^^^^^^^^^^^^^^
> Why do you define these unused parameters?
Because it's backported from 2.5, and I took it as it, without
editing.
> > +{
> > + free_pages((unsigned long)vaddr, get_order(size));
> > +}
>
> And why are they defined in 2.5, too, althought unused.
> Is there some reason?
Unused of ix86 because bus addresses are the same as virtual addresses.
This is not however the case on other architetures, see
Documentation/DMA-mapping.txt.
Stelian.
--
Stelian Pop <stelian@popies.net>
next prev parent reply other threads:[~2003-06-15 21:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-15 16:31 [PATCH 2.4.21] meye driver update Stelian Pop
2003-06-15 17:06 ` Michael Buesch
2003-06-15 21:29 ` Stelian Pop [this message]
2003-06-16 6:05 ` Stelian Pop
2003-06-16 14:54 ` Michael Buesch
2003-06-16 15:36 ` Stelian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030615212935.GA1582@deep-space-9.dsnet \
--to=stelian@popies.net \
--cc=fsdeveloper@yahoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox