Re: [PATCH 2.4.21] meye driver update

Stelian Pop
2003-06-15T21:15:53Z

On Sun, Jun 15, 2003 at 07:06:56PM +0200, Michael Buesch wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Sunday 15 June 2003 18:31, Stelian Pop wrote:
> > Hi,
>
> Hi Stelian,
>
> > +void dma_free_coherent(struct pci_dev *dev, size_t size,
> ^^^^^^^^^^^^^^^^^^^
> > + void *vaddr, dma_addr_t dma_handle)
> ^^^^^^^^^^^^^^^^^^^^^
> Why do you define these unused parameters?

Because it's backported from 2.5, and I took it as it, without
editing.

> > +{
> > + free_pages((unsigned long)vaddr, get_order(size));
> > +}
>
> And why are they defined in 2.5, too, althought unused.
> Is there some reason?

Unused of ix86 because bus addresses are the same as virtual addresses.
This is not however the case on other architetures, see
Documentation/DMA-mapping.txt.

Stelian.
--
Stelian Pop <stelian@popies.net>