Re: [PATCH 2.4.21] meye driver update

Stelian Pop
2003-06-16T15:23:00Z

On Mon, Jun 16, 2003 at 04:54:41PM +0200, Michael Buesch wrote:

> > Unused of ix86 because bus addresses are the same as virtual addresses.
> > This is not however the case on other architetures, see
> > Documentation/DMA-mapping.txt.
>
> Yes, I now understand, why it is in 2.5, but isn't it better,
> to remove these parameters from your patch, because it is only
> a local copy in your driver and not used by any other drivers.
> And your driver is (if I didn't miss something) for running on
> i386 only; there is no other version of this function for
> other architectures, that need these parameters.
> So wouldn't it be better to simply remove them, because
> they are completely useless. IMHO their
> just confusing.

No, I hope that the DMA allocation function will be backported in the
near future from 2.5 into 2.4. If I get some time, I may even do it
myself and propose a patch.

And when it's done, I'll just have to remove the two definitions
without changing anything in my code and it will just work.

Besides, having two versions (2.4 and 2.5) which don't diverge to much
is much easier for the maintainer.

Stelian.
--
Stelian Pop <stelian.pop@fr.alcove.com>
Alcove - http://www.alcove.com