From: DervishD <raul@pleyades.net>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND][PATCH] against mmap.c (do_mmap_pgoff) and a note
Date: Mon, 16 Jun 2003 11:49:11 +0200 [thread overview]
Message-ID: <20030616094911.GB43@DervishD> (raw)
In-Reply-To: <20030615102039.GA1063@wohnheim.fh-wedel.de>
* Jörn Engel <joern@wohnheim.fh-wedel.de> dixit:
> > - if (!len)
> > + if (len == 0)
> No change.
Just cosmethic, ask Dave S. Miller, he is the author of the
change, I'm just doing the patch for him.
> > return addr;
> >
> > - if (len > TASK_SIZE)
> > - return -EINVAL;
> > -
> > len = PAGE_ALIGN(len);
> >
> > + if (len > TASK_SIZE || len == 0)
> > + return -EINVAL;
> > +
>
> PAGE_ALIGN(0) = 0
> PAGE_ALIGN(1) = PAGE_SIZE
>
> Again, no change.
There is a change in archs where TASK_SIZE is the entire
addressable space (like sparc64). Ask Dave S., again. The problem did
arise when TASK_SIZE is ~0. Then semantics change.
Raúl Núñez de Arenas Coronado
--
Linux Registered User 88736
http://www.pleyades.net & http://raul.pleyades.net/
next prev parent reply other threads:[~2003-06-16 9:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-21 11:04 [RESEND][PATCH] against mmap.c (do_mmap_pgoff) and a note DervishD
[not found] ` <20030615102039.GA1063@wohnheim.fh-wedel.de>
2003-06-16 9:49 ` DervishD [this message]
2003-06-16 11:33 ` Jörn Engel
2003-06-16 12:58 ` DervishD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030616094911.GB43@DervishD \
--to=raul@pleyades.net \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox