From: Jeff <jeffpc@optonline.net>
To: Lincoln Dale <ltd@cisco.com>, Zwane Mwaikambo <zwane@linuxpower.ca>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 64-bit fields in struct net_device_stats
Date: Mon, 16 Jun 2003 10:02:41 -0400 [thread overview]
Message-ID: <200306161002.50506.jeffpc@optonline.net> (raw)
In-Reply-To: <5.1.0.14.2.20030616154156.0253dc98@mira-sjcm-3.cisco.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Monday 16 June 2003 01:47, Lincoln Dale wrote:
> why not a set of counters which are toggled between.
>
> e.g.
> struct netdevice... {
> uint64 tx_pkts_counter[2];
> uint64 tx_octets_counter[2];
> uint64 rx_pkts_counter[2];
> uint64 rx_octets_counter[2];
> int counter_bounce;
> ...
> }
<snip>
Hmm, interesting idea. The one thing is: There are 23 fields in struct
net_device_stats right now; if each of them is 64bits (=8 bytes), the whole
structure would be 184 bytes (with u_int64.) Now if I have two of each, the
size would grow to 368 bytes (plus the 4 bytes for counter_bounce). Now, the
question: would it be acceptable to have something that size?
Jeff.
- --
*NOTE: This message is ROT-13 encrypted twice for extra protection*
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
iD8DBQE+7c4FwFP0+seVj/4RAtGxAJsE+YY48y1mp+Y90FFH2Jz+hmU+fgCeK+gj
6ksJ8KxDYVo7rwxODwSAeT8=
=Sxo5
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2003-06-16 13:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-16 1:30 64-bit fields in struct net_device_stats Jeff
2003-06-16 2:53 ` Jeff
2003-06-16 3:12 ` Zwane Mwaikambo
2003-06-16 5:16 ` Zwane Mwaikambo
[not found] ` <Pine.LNX.4.50.0306152309220.32020-100000@montezuma.mastece nde.com>
2003-06-16 5:47 ` Lincoln Dale
2003-06-16 14:02 ` Jeff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200306161002.50506.jeffpc@optonline.net \
--to=jeffpc@optonline.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ltd@cisco.com \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox