Re: DVB updates, 3rd try

[jw schultz <jw@pegasys.ws>]

On Wed, Jun 18, 2003 at 05:12:54PM +0100, John Levon wrote:
> On Wed, Jun 18, 2003 at 08:58:43AM -0700, Linus Torvalds wrote:
> 
> > 	[DVB PATCH 1/9] Replace frobutomic counter with sequence numbers
> 
> People might find the below script (hacked from gregkh's version) useful
> for doing this. Should be fairly obvious.
> 
> regards,
> john
> 
> #!/usr/bin/perl -w
> 
> # horrible hack of a script to send off a large number of email messages, one after
> # each other, all chained together.  This is useful for large numbers of patches.
> #
> # Use at your own risk!!!!
> #
> # greg kroah-hartman Jan 8, 2002
> # <greg@kroah.com>
> #
> # Released under the artistic license.
> #
> 
> #
> # modify these options each time you run the script
> #
> #$to = 'torvalds@transmeta.com, linux-kernel@vger.kernel.org';
> $to = 'levon@movementarian.org';
> 
> # If you want to chain the first post, fill this in
> $initial_reply_to = '';
> 
> # a list of patches to send out
> @files = (
> ["shutdown.diff", "OProfile: small NMI shutdown fix"],
> ["ioapic.diff", "OProfile: IO-APIC based NMI delivery"],
> ["exec.diff", "OProfile: thread switching performance fix"],
> );
> 
> # Put your name and address here
> $from = "John Levon <levon\@movementarian.org>";
> 
> # Don't need to change anything below here...
> 
> use Mail::Sendmail;
> 
> 
> # we make a "fake" message id by taking the current number
> # of seconds since the beginning of Unix time and tacking on
> # a random number to the end, in case we are called quicker than
> # 1 second since the last time we were called.
> sub make_message_id
> {
> 	my $date = `date "+\%s"`;
> 	chomp($date);
> 	my $pseudo_rand = int (rand(4200));
> 	$message_id = "<$date$pseudo_rand\@movementarian.org>";
> 	print "new message id = $message_id\n";
> }
> 
> 
> 
> 
> 
> sub send_message
> {
> 	%mail = (	To	=>	$to,
> 			From	=>	$from,
> 			Subject	=>	$subject,
> 			Message	=>	$message,
> 			'In-Reply-To'	=>	$reply_to,
> 			'Message-ID'	=>	$message_id,
> 			'X-Mailer'	=> "gregkh_patchbomb_levon_offspring",
> 		);
> 
> 	$mail{smtp} = 'localhost';
> 
> 	sendmail(%mail) or die $Mail::Sendmail::error;
> 
> 	print "OK. Log says:\n", $Mail::Sendmail::log;
> 	print "\n\n"
> }
> 
> 
> $reply_to = $initial_reply_to;
> make_message_id();
> $nrfiles = @files;
> $current = 1;
> 
> foreach $t (@files) {
> 	($F, $subj) = @$t;
> 	open F or die "can't open file $t";
> 	undef $/;
> 	$message = <F>;	# slurp the whole file in
> 	close F;
> 	$/ = "\n";
> 	$subject = "[PATCH $current/$nrfiles] $subj";
> 	send_message();
> 
> 	# set up for the next message
> 	$reply_to = $message_id;

Please don't do this.  $reply_to ||= $message_id is OK but
having each patch as a reply to the previous one is
annoying.  I think it was Greg who recently posted one set
of patches that was so large the indentation for the thread
went off the screen.

       [PATCH 0/n] frob the niggle
       |-> [PATCH 1/n] frob the niggle
         |-> [PATCH 2/n] frob the niggle
           |-> [PATCH 3/n] frob the niggle
             |-> [PATCH 4/n] frob the niggle
               |-> [PATCH 5/n] frob the niggle
                 |-> [PATCH 6/n] frob the niggle
                   |-> [PATCH 7/n] frob the niggle
                     |-> [PATCH 8/n] frob the niggle
vs
       [PATCH 0/n] frob the niggle
       |-> [PATCH 1/n] frob the niggle
       |-> [PATCH 2/n] frob the niggle
       |-> [PATCH 3/n] frob the niggle
       |-> [PATCH 4/n] frob the niggle
       |-> [PATCH 5/n] frob the niggle
       |-> [PATCH 6/n] frob the niggle
       |-> [PATCH 7/n] frob the niggle
       |-> [PATCH 8/n] frob the niggle

> 	make_message_id();
> 	$current++;
> }

Other than that, thanks. If more people posted patch sets
like this it would be much nicer.

-- 
________________________________________________________________
	J.W. Schultz            Pegasystems Technologies
	email address:		jw@pegasys.ws

		Remember Cernan and Schmitt