Re: [PATCH] PnP Changes for 2.5.72

[Russell King <rmk@arm.linux.org.uk>]

On Wed, Jun 18, 2003 at 11:44:18PM +0000, Adam Belay wrote:
> diff -Nru a/drivers/serial/8250_pnp.c b/drivers/serial/8250_pnp.c
> --- a/drivers/serial/8250_pnp.c	Wed Jun 18 23:02:24 2003
> +++ b/drivers/serial/8250_pnp.c	Wed Jun 18 23:02:24 2003
> @@ -315,19 +315,6 @@
>  
>  MODULE_DEVICE_TABLE(pnp, pnp_dev_table);
>  
> -static inline void avoid_irq_share(struct pnp_dev *dev)
> -{
> -	unsigned int map = 0x1FF8;
> -	struct pnp_irq *irq;
> -	struct pnp_resources *res = dev->possible;
> -
> -	serial8250_get_irq_map(&map);
> -
> -	for ( ; res; res = res->dep)
> -		for (irq = res->irq; irq; irq = irq->next)
> -			irq->map = map;
> -}
> -
>  static char *modem_names[] __devinitdata = {
>  	"MODEM", "Modem", "modem", "FAX", "Fax", "fax",
>  	"56K", "56k", "K56", "33.6", "28.8", "14.4",
> @@ -395,8 +391,6 @@
>  		if (ret < 0)
>  			return ret;
>  	}
> -	if (flags & SPCI_FL_NO_SHIRQ)
> -		avoid_irq_share(dev);
>  	memset(&serial_req, 0, sizeof(serial_req));
>  	serial_req.irq = pnp_irq(dev,0);
>  	serial_req.port = pnp_port_start(dev, 0);

Why did you remove this?  I'd like this to go to Linus as a separate cset
so it can easily be backed out again if needed.

It's purpose is trying to ensure that we don't use an interrupt which
another serial port is using.  Presumably this is because the card does
not work, for whatever reason, when it shares interrupts with other serial
ports.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html