From: Joshua Kwan <joshk@triplehelix.org>
To: Magnus Solvang <magnus@solvang.net>
Cc: linux-kernel mailing list <linux-kernel@vger.kernel.org>,
kai.germaschewski@gmx.de, kkeil@suse.de
Subject: Re: isdn compile-errors (Linux 2.5.72)
Date: Thu, 19 Jun 2003 10:30:19 -0700 [thread overview]
Message-ID: <20030619173019.GA30548@triplehelix.org> (raw)
In-Reply-To: <20030619114807.GD3991@first.knowledge.no>
[-- Attachment #1.1: Type: text/plain, Size: 917 bytes --]
On Thu, Jun 19, 2003 at 01:48:07PM +0200, Magnus Solvang wrote:
> drivers/isdn/i4l/isdn_tty.c: In function `isdn_tty_write':
> drivers/isdn/i4l/isdn_tty.c:1198: warning: unused variable `m'
*snip*
> drivers/isdn/i4l/isdn_tty.c: In function `isdn_tty_init':
> drivers/isdn/i4l/isdn_tty.c:2099: invalid type argument of `->'
> drivers/isdn/i4l/isdn_tty.c:2101: invalid type argument of `->'
> drivers/isdn/i4l/isdn_tty.c:2102: invalid type argument of `->'
*snip*
> drivers/isdn/i4l/isdn_tty.c: In function `isdn_tty_exit':
> drivers/isdn/i4l/isdn_tty.c:2121: invalid type argument of `->'
> drivers/isdn/i4l/isdn_tty.c:2122: invalid type argument of `->'
> drivers/isdn/i4l/isdn_tty.c:2123: invalid type argument of `->'
Attached patch should fix these, though I've not tested it.
(I hope I CC'd the right people.) Should apply against 2.5.72
vanilla.
-Josh
--
New PGP public key: 0x27AFC3EE
[-- Attachment #1.2: isdn_not_pointer.patch --]
[-- Type: text/plain, Size: 1133 bytes --]
diff -ur linux-2.5.72.v/drivers/isdn/i4l/isdn_tty.c linux/drivers/isdn/i4l/isdn_tty.c
--- linux-2.5.72.v/drivers/isdn/i4l/isdn_tty.c 2003-06-16 21:20:19.000000000 -0700
+++ linux/drivers/isdn/i4l/isdn_tty.c 2003-06-19 10:26:13.000000000 -0700
@@ -1195,7 +1195,6 @@
int c;
int total = 0;
modem_info *info = (modem_info *) tty->driver_data;
- atemu *m = &info->emu;
if (isdn_tty_paranoia_check(info, tty->name, "isdn_tty_write"))
return 0;
@@ -2096,10 +2095,10 @@
kfree(info->xmit_buf - 4);
}
err_unregister_tty:
- tty_unregister_driver(&isdn_mdm->tty_modem);
+ tty_unregister_driver(&isdn_mdm.tty_modem);
err:
- put_tty_driver(&isdn_mdm->tty_modem);
- isdn_mdm->tty_modem = NULL;
+ put_tty_driver(&isdn_mdm.tty_modem);
+ isdn_mdm.tty_modem = NULL;
return retval;
}
@@ -2118,9 +2117,9 @@
#endif
kfree(info->xmit_buf - 4);
}
- tty_unregister_driver(&isdn_mdm->tty_modem);
- put_tty_driver(&isdn_mdm->tty_modem);
- isdn_mdm->tty_modem = NULL;
+ tty_unregister_driver(&isdn_mdm.tty_modem);
+ put_tty_driver(&isdn_mdm.tty_modem);
+ isdn_mdm.tty_modem = NULL;
}
/*
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2003-06-19 17:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-19 11:48 isdn compile-errors (Linux 2.5.72) Magnus Solvang
2003-06-19 17:30 ` Joshua Kwan [this message]
2003-06-19 17:48 ` Kai Germaschewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030619173019.GA30548@triplehelix.org \
--to=joshk@triplehelix.org \
--cc=kai.germaschewski@gmx.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus@solvang.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox