From: Joe Korty <joe.korty@ccur.com>
To: Robert Love <rml@tech9.net>
Cc: george anzinger <george@mvista.com>,
"Perez-Gonzalez, Inaky" <inaky.perez-gonzalez@intel.com>,
"'Andrew Morton'" <akpm@digeo.com>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'mingo@elte.hu'" <mingo@elte.hu>, "Li, Adam" <adam.li@intel.com>
Subject: Re: [patch] setscheduler fix
Date: Thu, 19 Jun 2003 14:20:57 -0400 [thread overview]
Message-ID: <20030619182057.GA1228@rudolph.ccur.com> (raw)
In-Reply-To: <1056044732.8770.39.camel@localhost>
> Here is my patch. It is the same idea as Joe's. Is there a better fix?
>
> Basically, the problem is that setscheduler() does not set need_resched
> when needed. There are two basic cases where this is needed:
>
> - the task is running, but now it is no longer the highest
> priority task on the rq
> - the task is not running, but now it is the highest
> priority task on the rq
>
> In either case, we need to set need_resched to invoke the scheduler.
>
> Patch is against 2.5.72. Comments?
Looks good to me.
migration_thread and try_to_wake_up already have a simplier version of
your test that seems to be correct for that environment, so no change
is needed there.
wake_up_forked_process in principle might need your patch, but as it
appears to be called only from boot code it is unimportant that it
have the lowest possible latency, so no change is needed there either.
Joe
next prev parent reply other threads:[~2003-06-19 18:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-19 6:06 O(1) scheduler seems to lock up on sched_FIFO and sched_RR ta sks Perez-Gonzalez, Inaky
2003-06-19 6:07 ` Ingo Molnar
2003-06-19 16:00 ` george anzinger
2003-06-19 17:19 ` 'joe.korty@ccur.com'
2003-06-19 17:23 ` Robert Love
2003-06-19 17:28 ` Joe Korty
2003-06-19 17:45 ` [patch] setscheduler fix Robert Love
2003-06-19 18:20 ` Joe Korty [this message]
2003-06-19 18:38 ` Robert Love
2003-06-19 19:09 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2003-06-20 2:38 Perez-Gonzalez, Inaky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030619182057.GA1228@rudolph.ccur.com \
--to=joe.korty@ccur.com \
--cc=adam.li@intel.com \
--cc=akpm@digeo.com \
--cc=george@mvista.com \
--cc=inaky.perez-gonzalez@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox