* [2.5 patch] remove an unused variable from xirc2ps_cs.c
@ 2003-06-20 0:10 Adrian Bunk
2003-06-20 4:36 ` Rusty Russell
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2003-06-20 0:10 UTC (permalink / raw)
To: dahinds; +Cc: linux-kernel, linux-net, trivial
The platch below removes an unused variable from
drivers/net/pcmcia/xirc2ps_cs.c .
Please apply
Adrian
--- linux-2.5.72-mm2/drivers/net/pcmcia/xirc2ps_cs.c.old 2003-06-20 02:07:40.000000000 +0200
+++ linux-2.5.72-mm2/drivers/net/pcmcia/xirc2ps_cs.c 2003-06-20 02:07:55.000000000 +0200
@@ -225,9 +225,7 @@
#else
#define DEBUG(n, args...)
#endif
-static char *version =
-"xirc2ps_cs.c 1.31 1998/12/09 19:32:55 (dd9jn+kvh)";
- /* !--- CVS revision */
+
#define KDBG_XIRC KERN_DEBUG "xirc2ps_cs: "
#define KERR_XIRC KERN_ERR "xirc2ps_cs: "
#define KWRN_XIRC KERN_WARNING "xirc2ps_cs: "
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.5 patch] remove an unused variable from xirc2ps_cs.c
2003-06-20 0:10 [2.5 patch] remove an unused variable from xirc2ps_cs.c Adrian Bunk
@ 2003-06-20 4:36 ` Rusty Russell
2003-06-20 17:12 ` Adrian Bunk
0 siblings, 1 reply; 3+ messages in thread
From: Rusty Russell @ 2003-06-20 4:36 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel, linux-net, trivial
In message <20030620001049.GI29247@fs.tum.de> you write:
> The platch below removes an unused variable from
> drivers/net/pcmcia/xirc2ps_cs.c .
Please add __attribute_used__ instead, since the author presumably
wants the string left in.
Cheers,
Rusty.
> --- linux-2.5.72-mm2/drivers/net/pcmcia/xirc2ps_cs.c.old 2003-06-20 02:07:40.000000000 +0200
> +++ linux-2.5.72-mm2/drivers/net/pcmcia/xirc2ps_cs.c 2003-06-20 02:07:55.000000000 +0200
> @@ -225,9 +225,7 @@
> #else
> #define DEBUG(n, args...)
> #endif
> -static char *version =
> -"xirc2ps_cs.c 1.31 1998/12/09 19:32:55 (dd9jn+kvh)";
> - /* !--- CVS revision */
> +
> #define KDBG_XIRC KERN_DEBUG "xirc2ps_cs: "
> #define KERR_XIRC KERN_ERR "xirc2ps_cs: "
> #define KWRN_XIRC KERN_WARNING "xirc2ps_cs: "
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.5 patch] remove an unused variable from xirc2ps_cs.c
2003-06-20 4:36 ` Rusty Russell
@ 2003-06-20 17:12 ` Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2003-06-20 17:12 UTC (permalink / raw)
To: Rusty Russell; +Cc: linux-kernel, linux-net, trivial, daniel.ritz
On Fri, Jun 20, 2003 at 02:36:01PM +1000, Rusty Russell wrote:
> In message <20030620001049.GI29247@fs.tum.de> you write:
> > The platch below removes an unused variable from
> > drivers/net/pcmcia/xirc2ps_cs.c .
>
> Please add __attribute_used__ instead, since the author presumably
> wants the string left in.
I'd agree if the author was still active. All the changes to this
driver in the near past weren't done by Werner Koch (dd9jn). Since
the version isn't updated when the driver is updated and this string is
no longer used in 2.5 (it was displayed in 2.4) I consider it quite
obsolete.
> Cheers,
> Rusty.
>
> > --- linux-2.5.72-mm2/drivers/net/pcmcia/xirc2ps_cs.c.old 2003-06-20 02:07:40.000000000 +0200
> > +++ linux-2.5.72-mm2/drivers/net/pcmcia/xirc2ps_cs.c 2003-06-20 02:07:55.000000000 +0200
> > @@ -225,9 +225,7 @@
> > #else
> > #define DEBUG(n, args...)
> > #endif
> > -static char *version =
> > -"xirc2ps_cs.c 1.31 1998/12/09 19:32:55 (dd9jn+kvh)";
> > - /* !--- CVS revision */
> > +
> > #define KDBG_XIRC KERN_DEBUG "xirc2ps_cs: "
> > #define KERR_XIRC KERN_ERR "xirc2ps_cs: "
> > #define KWRN_XIRC KERN_WARNING "xirc2ps_cs: "
> --
> Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-06-20 17:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-06-20 0:10 [2.5 patch] remove an unused variable from xirc2ps_cs.c Adrian Bunk
2003-06-20 4:36 ` Rusty Russell
2003-06-20 17:12 ` Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox