From: Rusty Russell <rusty@rustcorp.com.au>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: linux-kernel@vger.kernel.org, linux-net@vger.kernel.org,
trivial@rustcorp.com.au
Subject: Re: [2.5 patch] remove an unused variable from xirc2ps_cs.c
Date: Fri, 20 Jun 2003 14:36:01 +1000 [thread overview]
Message-ID: <20030620050950.38D362C129@lists.samba.org> (raw)
In-Reply-To: Your message of "Fri, 20 Jun 2003 02:10:49 +0200." <20030620001049.GI29247@fs.tum.de>
In message <20030620001049.GI29247@fs.tum.de> you write:
> The platch below removes an unused variable from
> drivers/net/pcmcia/xirc2ps_cs.c .
Please add __attribute_used__ instead, since the author presumably
wants the string left in.
Cheers,
Rusty.
> --- linux-2.5.72-mm2/drivers/net/pcmcia/xirc2ps_cs.c.old 2003-06-20 02:07:40.000000000 +0200
> +++ linux-2.5.72-mm2/drivers/net/pcmcia/xirc2ps_cs.c 2003-06-20 02:07:55.000000000 +0200
> @@ -225,9 +225,7 @@
> #else
> #define DEBUG(n, args...)
> #endif
> -static char *version =
> -"xirc2ps_cs.c 1.31 1998/12/09 19:32:55 (dd9jn+kvh)";
> - /* !--- CVS revision */
> +
> #define KDBG_XIRC KERN_DEBUG "xirc2ps_cs: "
> #define KERR_XIRC KERN_ERR "xirc2ps_cs: "
> #define KWRN_XIRC KERN_WARNING "xirc2ps_cs: "
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2003-06-20 4:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-20 0:10 [2.5 patch] remove an unused variable from xirc2ps_cs.c Adrian Bunk
2003-06-20 4:36 ` Rusty Russell [this message]
2003-06-20 17:12 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030620050950.38D362C129@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox