From: Rusty Russell <rusty@rustcorp.com.au>
To: Thiago Rondon <thiago@nl.linux.org>
Cc: viro@parcelfarce.linux.theplanet.co.uk,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
trivial@rustcorp.com.au
Subject: Re: [2.5 patch] 2.5.72: moxa.c doesn't compile
Date: Fri, 20 Jun 2003 14:28:13 +1000 [thread overview]
Message-ID: <20030620050950.46DDC2C150@lists.samba.org> (raw)
In-Reply-To: Your message of "Thu, 19 Jun 2003 15:53:53 -0300." <20030619185352.GB421@ananke.com.br>
In message <20030619185352.GB421@ananke.com.br> you write:
> @@ -654,7 +658,7 @@
> if (ch == NULL)
> return (0);
> port = ch->port;
> - save_flags(flags);
> + local_save_flags(flags);
> if (from_user) {
> if (count > PAGE_SIZE)
> count = PAGE_SIZE;
> @@ -662,17 +666,17 @@
> if (copy_from_user(moxaXmitBuff, buf, count)) {
> len = -EFAULT;
> } else {
> - cli();
> + spin_lock_irqsave(&moxa_lock, flags);
Just drop the local_save_flags() altogether; it's redundant.
> /*********************************************
> @@ -751,11 +755,11 @@
> if (ch == NULL)
> return;
> port = ch->port;
> - save_flags(flags);
> - cli();
> + local_save_flags(flags);
> + spin_lock_irqsave(&moxa_lock, flags);
Here too...
Cheers,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
prev parent reply other threads:[~2003-06-20 4:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-14 21:17 Linux 2.5.71 Linus Torvalds
2003-06-15 1:42 ` Florin Iucha
2003-06-15 1:58 ` Linus Torvalds
2003-06-15 2:00 ` Florin Iucha
2003-06-15 4:55 ` Florin Iucha
2003-06-15 8:03 ` Trond Myklebust
2003-06-15 6:54 ` Andre Hedrick
2003-06-15 7:15 ` Andre Hedrick
2003-06-15 13:29 ` Paweł Gołaszewski
2003-06-15 13:45 ` Russell King
2003-06-16 18:04 ` John Cherry
2003-06-17 19:29 ` [2.5 patch] 2.5.72: moxa.c doesn't compile Adrian Bunk
2003-06-17 23:33 ` viro
2003-06-19 18:53 ` Thiago Rondon
2003-06-20 4:28 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030620050950.46DDC2C150@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=thiago@nl.linux.org \
--cc=trivial@rustcorp.com.au \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox