public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Isaacson <adi@hexapodia.org>
To: Marcelo Tosatti <marcelo@conectiva.com.br>, linux-kernel@vger.kernel.org
Subject: dnotify readv/writev fix for 2.4.21
Date: Fri, 20 Jun 2003 16:39:50 -0500	[thread overview]
Message-ID: <20030620163950.A8502@hexapodia.org> (raw)

Marcelo,

This patch didn't make it into 2.4.21.  Zou Pengcheng's original patch
was whitespace-damaged, so here's a fresh copy against 2.4.21.

Issue DN_MODIFY on writev, and DN_ACCESS on readv, rather than vice versa.

I can provide a testcase if anyone wants one.

----- Forwarded message from Zou Pengcheng <pczou@redflag-linux.com> -----

From: Zou Pengcheng <pczou@redflag-linux.com>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] dnotify fix for readv/writev (Linux 2.4.20)
Date:	Mon, 2 Dec 2002 09:22:43 +0800
Message-Id: <200212020922.43820.pczou@redflag-linux.com>

hi, Marcelo,

this is a patch to fix the dnotify bug of readv/writev. 

Orignally DN_MODIFY is issued on readv while DN_ACCESS is issued on writev, 
which is obviously wrong. This patch fixes such problem.

cheers,
  -- Pengcheng Zou

diff -uNr fs/read_write.c.orig fs/read_write.c
...

----- End forwarded message -----


--- linux-2.4.21/fs/read_write.c	Fri Jun 13 09:51:37 2003
+++ linux-2.4.21-dnotify-fix/fs/read_write.c	Thu Jun 19 11:55:30 2003
@@ -322,7 +322,7 @@
 	/* VERIFY_WRITE actually means a read, as we write to user space */
 	if ((ret + (type == VERIFY_WRITE)) > 0)
 		dnotify_parent(file->f_dentry,
-			(type == VERIFY_WRITE) ? DN_MODIFY : DN_ACCESS);
+			(type == VERIFY_WRITE) ? DN_ACCESS : DN_MODIFY);
 	return ret;
 }
 

-andy

                 reply	other threads:[~2003-06-20 21:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030620163950.A8502@hexapodia.org \
    --to=adi@hexapodia.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox