2.5: wrong CONFIG_SND_SEQUENCER logic in several drivers

[Adrian Bunk <bunk@fs.tum.de>]

On Fri, Jun 20, 2003 at 11:04:47PM +0200, Fabio Bracci wrote:

> Hi
> 	Hereby I have attached the requested .conf file ("config.2.5.70").
> I tried again to compile a kernel, but now using the 2.5.72 one. But
> again something went wrong while compiling the sound subsystem. That's
> why I attacched also the new .conf file ("config.2.5.70").
> I now got the following messages:
> ...
>...
>   LD      vmlinux
> sound/built-in.o(.text+0x1b6ea): In function `snd_rawmidi_dev_register':
> : undefined reference to `snd_seq_device_new'
> sound/built-in.o(.text+0x22fb8): In function `snd_card_emu10k1_probe':
> : undefined reference to `snd_seq_device_new'
> make: *** [vmlinux] Error 1
> 
> 
> Hopefully this will help.

Yup, thanks a lot!

> Greetings,
> 	Fabio ...
>...
> #
> # Advanced Linux Sound Architecture
> #
> CONFIG_SND=y
> CONFIG_SND_SEQUENCER=m
> CONFIG_SND_SEQ_DUMMY=m
> # CONFIG_SND_OSSEMUL is not set
> CONFIG_SND_RTCTIMER=m
> CONFIG_SND_VERBOSE_PRINTK=y
> # CONFIG_SND_DEBUG is not set
>...
> CONFIG_SND_EMU10K1=y
>...


This is a bug in several ALSA drivers.

@Fabio:
As a workaround, compile "Sequencer support" statically (non-modular).

@Jaroslav:
Several drivers have a wrong logic for CONFIG_SND_SEQUENCER. The correct 
solution is something like the following:

--- sound/pci/emu10k1/emu10k1.c.old	2003-06-21 03:02:04.000000000 +0200
+++ sound/pci/emu10k1/emu10k1.c	2003-06-21 03:02:31.000000000 +0200
@@ -35,7 +35,7 @@
 MODULE_DEVICES("{{Creative Labs,SB Live!/PCI512/E-mu APS},"
 	       "{Creative Labs,SB Audigy}}");
 
-#if defined(CONFIG_SND_SEQUENCER) || defined(CONFIG_SND_SEQUENCER_MODULE)
+#if defined(CONFIG_SND_SEQUENCER) || (defined (MODULE) && defined(CONFIG_SND_SEQUENCER_MODULE))
 #define ENABLE_SYNTH
 #include <sound/emu10k1_synth.h>
 #endif

If you comfirm this is correct I'll send a fix for all affected drivers.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed