From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] fix sysfs bogosity in i82365.c
Date: Sat, 21 Jun 2003 22:51:29 -0300 [thread overview]
Message-ID: <20030622015129.GE10801@conectiva.com.br> (raw)
Hi Linus,
Please consider applying, it was using a non-existent socket[] index
and not doing it for all sockets.
Without this, forget about using i82365, crashes on boot :-)
- Arnaldo
===== drivers/pcmcia/i82365.c 1.36 vs edited =====
--- 1.36/drivers/pcmcia/i82365.c Sun Jun 15 12:20:52 2003
+++ edited/drivers/pcmcia/i82365.c Sat Jun 21 22:09:08 2003
@@ -1471,6 +1471,10 @@
pcmcia_unregister_socket(&socket[i].socket);
break;
}
+ class_device_create_file(&socket[i].socket.dev,
+ &class_device_attr_info);
+ class_device_create_file(&socket[i].socket.dev,
+ &class_device_attr_exca);
}
/* Finally, schedule a polling interrupt */
@@ -1481,9 +1485,6 @@
poll_timer.expires = jiffies + poll_interval;
add_timer(&poll_timer);
}
-
- class_device_create_file(&socket[i].socket.dev, &class_device_attr_info);
- class_device_create_file(&socket[i].socket.dev, &class_device_attr_exca);
return 0;
reply other threads:[~2003-06-22 1:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030622015129.GE10801@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox