From: Jens Axboe <axboe@suse.de>
To: Lou Langholtz <ldl@aros.net>
Cc: Andrew Morton <akpm@digeo.com>,
viro@parcelfarce.linux.theplanet.co.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nbd driver 2.5+: fix for incorrect struct bio usage
Date: Sun, 22 Jun 2003 10:50:06 +0200 [thread overview]
Message-ID: <20030622085006.GH608@suse.de> (raw)
In-Reply-To: <3EF4E5A9.5010802@aros.net>
On Sat, Jun 21 2003, Lou Langholtz wrote:
> Here's a possible patch #2... I believe the address pointed to by
> bio_data(bio) is not always contiguous over the length of bio->bi_size
> and was responsible for locking my machine up sometimes. My biggest
> reason for apprehension on believeing that I'm 100% correct on this is
> that there's still what appears to be a source of memory corruption in
> the patchlet modified nbd driver even after this patch. I know the
> driver is still not correctly notifying processes of the bytesize on
> open but the size reported appears to be big enough. Anyway, thanks for
> all of the feedback so far!!!!
You are correct, the current code breaks down for multi-page bio's. It
looks like you are missing a kmap still though, bvec->bv_page could be a
highmem page.
--
Jens Axboe
prev parent reply other threads:[~2003-06-22 8:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-21 21:48 [PATCH] nbd driver for 2.5+: fix for module removal & new block device layer Lou Langholtz
2003-06-21 22:55 ` viro
2003-06-21 23:16 ` Lou Langholtz
2003-06-22 10:03 ` Jens Axboe
[not found] ` <20030621151818.081139fc.akpm@digeo.com>
2003-06-21 23:09 ` [PATCH] nbd driver 2.5+: fix for incorrect struct bio usage Lou Langholtz
2003-06-22 8:50 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030622085006.GH608@suse.de \
--to=axboe@suse.de \
--cc=akpm@digeo.com \
--cc=ldl@aros.net \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox