Re: [PATCH] Isapnp warning

[Jan-Benedict Glaw <jbglaw@lug-owl.de>]

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]

On Sun, 2003-06-22 16:07:14 +0200, Daniel Phillips <phillips@arcor.de>
wrote in message <200306221607.15232.phillips@arcor.de>:
> Hi Alan,
> 
> On Saturday 21 June 2003 14:31, Alan Cox wrote:
> > On Sul, 2003-06-15 at 19:36, Geert Uytterhoeven wrote:
> 
> How about:
> 
>    #define if_pci(tokens...) tokens
> 
>    int pnp_add_irq_resource(struct pnp_dev *dev, int depnum, struct pnp_irq *data)
>    {
> 	if_pci(int i);
> 	...
>    }
> 
> Admittedly uglier than just having the warning disabled by default.

Even whilest I don't like defining variables where I need them (at an
opening "{" or like in "for (int i, i < x, i++)" as Linus suggested it),
this is quite ugly, too. "if_pci(int i)" looks linke an uglyfied
function call, and even while being ugly, it should basically "work"
like a function call. Here, it doesn't, so I consider this a Bad Thing.

MfG, JBG

-- 
   Jan-Benedict Glaw       jbglaw@lug-owl.de    . +49-172-7608481
   "Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg
    fuer einen Freien Staat voll Freier Bürger" | im Internet! |   im Irak!
      ret = do_actions((curr | FREE_SPEECH) & ~(IRAQ_WAR_2 | DRM | TCPA));

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]