From: Adrian Bunk <bunk@fs.tum.de>
To: Dave Jones <davej@suse.de>
Cc: linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
Subject: [2.5 patch] small cleanups for amd-k8-agp.c
Date: Tue, 24 Jun 2003 19:19:26 +0200 [thread overview]
Message-ID: <20030624171926.GP3710@fs.tum.de> (raw)
Hi Dave,
the patch below does the following trivial cleanups to
drivers/char/agp/amd-k8-agp.c:
- postfix three constants with ULL
- remove a variable that isn't needed
Please apply
Adrian
--- linux-2.5.73-not-full/drivers/char/agp/amd-k8-agp.c.old 2003-06-23 22:26:27.000000000 +0200
+++ linux-2.5.73-not-full/drivers/char/agp/amd-k8-agp.c 2003-06-23 22:27:21.000000000 +0200
@@ -47,7 +47,6 @@
static int x86_64_insert_memory(struct agp_memory *mem, off_t pg_start, int type)
{
int i, j, num_entries;
- long tmp;
u32 pte;
u64 addr;
@@ -78,10 +77,9 @@
for (i = 0, j = pg_start; i < mem->page_count; i++, j++) {
addr = agp_bridge->driver->mask_memory(mem->memory[i], mem->type);
- tmp = addr;
- BUG_ON(tmp & 0xffffff0000000ffc);
- pte = (tmp & 0x000000ff00000000) >> 28;
- pte |=(tmp & 0x00000000fffff000);
+ BUG_ON(addr & 0xffffff0000000ffcULL);
+ pte = (addr & 0x000000ff00000000ULL) >> 28;
+ pte |=(addr & 0x00000000fffff000ULL);
pte |= 1<<1|1<<0;
agp_bridge->gatt_table[j] = pte;
next reply other threads:[~2003-06-24 17:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-24 17:19 Adrian Bunk [this message]
2003-06-26 0:57 ` [2.5 patch] small cleanups for amd-k8-agp.c Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030624171926.GP3710@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=davej@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox