public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: "David S. Miller" <davem@redhat.com>, Jeff Garzik <jgarzik@pobox.com>
Cc: linux-net@vger.kernel.org, linux-kernel@vger.kernel.org,
	trivial@rustcorp.com.au
Subject: [2.5 patch] ULL postfixes for tg3.c
Date: Tue, 24 Jun 2003 19:48:11 +0200	[thread overview]
Message-ID: <20030624174811.GW3710@fs.tum.de> (raw)

The patch below adds ULL postfixes to three constants in tg3.c .

There's no need to create an int constant and later cast it to u64.

The second case was also incorrect since the constant was too big for an 
int.

Please apply
Adrian

--- linux-2.5.73-not-full/drivers/net/tg3.c.old	2003-06-24 19:42:20.000000000 +0200
+++ linux-2.5.73-not-full/drivers/net/tg3.c	2003-06-24 19:43:47.000000000 +0200
@@ -6679,16 +6679,16 @@
 	}
 
 	/* Configure DMA attributes. */
-	if (!pci_set_dma_mask(pdev, (u64) 0xffffffffffffffffULL)) {
+	if (!pci_set_dma_mask(pdev, 0xffffffffffffffffULL)) {
 		pci_using_dac = 1;
 		if (pci_set_consistent_dma_mask(pdev,
-						(u64) 0xffffffffffffffff)) {
+						0xffffffffffffffffULL)) {
 			printk(KERN_ERR PFX "Unable to obtain 64 bit DMA "
 			       "for consistent allocations\n");
 			goto err_out_free_res;
 		}
 	} else {
-		err = pci_set_dma_mask(pdev, (u64) 0xffffffff);
+		err = pci_set_dma_mask(pdev, 0xffffffffULL);
 		if (err) {
 			printk(KERN_ERR PFX "No usable DMA configuration, "
 			       "aborting.\n");

             reply	other threads:[~2003-06-24 17:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-24 17:48 Adrian Bunk [this message]
2003-06-24 20:12 ` [2.5 patch] ULL postfixes for tg3.c David S. Miller
2003-06-24 20:32   ` Arjan van de Ven
2003-06-24 20:34   ` Jeff Garzik
  -- strict thread matches above, loose matches on Subject: below --
2003-06-24 18:00 Eble, Dan
2003-06-24 18:20 ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030624174811.GW3710@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=davem@redhat.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    --cc=trivial@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox