From: Dave Jones <davej@codemonkey.org.uk>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
Subject: Re: [2.5 patch] small cleanups for amd-k8-agp.c
Date: Thu, 26 Jun 2003 01:57:30 +0100 [thread overview]
Message-ID: <20030626005729.GB18101@suse.de> (raw)
In-Reply-To: <20030624171926.GP3710@fs.tum.de>
On Tue, Jun 24, 2003 at 07:19:26PM +0200, Adrian Bunk wrote:
> the patch below does the following trivial cleanups to
> drivers/char/agp/amd-k8-agp.c:
> - postfix three constants with ULL
> - remove a variable that isn't needed
>
> Please apply
Rejected. That whole block of code is bogus when run in 32 bit mode.
The ULL warnings that are currently emitted by gcc serve as reminders for
me to get off my arse and fix it some day.
Dave
prev parent reply other threads:[~2003-06-26 0:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-24 17:19 [2.5 patch] small cleanups for amd-k8-agp.c Adrian Bunk
2003-06-26 0:57 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030626005729.GB18101@suse.de \
--to=davej@codemonkey.org.uk \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox