public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kurt Wall <kwall@kurtwerks.com>
To: "J.A. Magallon" <jamagallon@able.es>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix inlining with gcc3
Date: Thu, 26 Jun 2003 19:36:21 -0400	[thread overview]
Message-ID: <20030626233621.GC20094@kurtwerks.com> (raw)
In-Reply-To: <20030626230824.GM3827@werewolf.able.es>

[CCs slightly trimmed]

Quoth J.A. Magallon:

[snippety]
 
> This fixes inlining (really, not-inlining) with gcc3. How about next -pre ?
> 
> --- 25/include/linux/compiler.h~gcc3-inline-fix	2003-03-06 03:02:43.000000000 -0800
> +++ 25-akpm/include/linux/compiler.h	2003-03-06 03:11:42.000000000 -0800
> @@ -1,6 +1,13 @@
>  #ifndef __LINUX_COMPILER_H
>  #define __LINUX_COMPILER_H
>  
> +#if __GNUC__ >= 3
> +#define inline		__inline__ __attribute__((always_inline))
> +#define inline__	__inline__ __attribute__((always_inline))
> +#define __inline	__inline__ __attribute__((always_inline))
> +#define __inline__	__inline__ __attribute__((always_inline))
> +#endif
> +
>  /* Somewhere in the middle of the GCC 2.96 development cycle, we implemented
>     a mechanism by which the user can annotate likely branch directions and
>     expect the blocks to be reordered appropriately.  Define __builtin_expect

I'm willing to give this a shot. Where, or perhaps what, should I test
to evaluate best the effects, if any, of this patch? 

Kurt
-- 
Decision maker, n.:
	The person in your office who was unable to form a task force
before the music stopped.

  reply	other threads:[~2003-06-26 23:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-26 22:03 Linux 2.4.22-pre2 Marcelo Tosatti
2003-06-26 22:54 ` J.A. Magallon
2003-06-26 23:06 ` [PATCH] gcc_check for x86 J.A. Magallon
2003-06-26 23:08 ` [PATCH] fix inlining with gcc3 J.A. Magallon
2003-06-26 23:36   ` Kurt Wall [this message]
2003-06-27 10:50   ` Alan Cox
2003-06-27 14:22     ` J.A. Magallon
2003-06-26 23:31 ` [PATCH] kill extra printk prototype J.A. Magallon
2003-06-27 14:02   ` Adrian Bunk
2003-06-26 23:32 ` [PATCH] kill duplicate pci_id J.A. Magallon
2003-06-27  5:59 ` Linux 2.4.22-pre2 Marc-Christian Petersen
2003-06-27  8:44 ` Matthias Andree
2003-06-27 17:58 ` [2.4 patch] some gcc 3.3 fixes from -ac Adrian Bunk
2003-06-27 18:56 ` Linux 2.4.22-pre2 Alessandro Suardi
2003-06-27 23:36 ` [BUG?] do_generic_direct_write J.A. Magallon
2003-07-04 20:55   ` J.A. Magallon
2003-06-27 23:38 ` Linux 2.4.22-pre2 Krzysztof Halasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030626233621.GC20094@kurtwerks.com \
    --to=kwall@kurtwerks.com \
    --cc=jamagallon@able.es \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox