Re: [PATCH] fix for kallsyms module symbol resolution problem

[Rusty Russell <rusty@rustcorp.com.au>]

In message <1056770789.1825.200.camel@mulgrave> you write:
> In lots of KALLSYMS symbol resolution in modules, I've noticed the
> appearance of symbols with no names:
> 
> Jun 27 20:55:26 raven kernel:  [<10131440>] schedule_timeout+0x78/0xdc
> Jun 27 20:55:26 raven kernel:  [<000f8240>] +0x4e0/0x598 [sunrpc]
> Jun 27 20:55:26 raven kernel:  [<0014504c>] +0x150/0x43c [nfsd]
> Jun 27 20:55:26 raven kernel:  [<10109c5c>] ret_from_kernel_thread+0x1c/0x24
> 
> The problem seems to be that get_ksymbol doesn't eliminate empty symbol
> names when it does resolution.  The attached patch should fix this.

Please test, because that's only one problem.

The other is that the module_text_address() returns true if the value
is within the module, *not* just if it's within a function.  So you
can get some noise there, too, on archs which don't do real
backtracing.

Thanks,
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.