From: Daniel Jacobowitz <dan@debian.org>
To: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: [PTRACE PATCH] Report detached thread exit to the debugger
Date: Sun, 29 Jun 2003 23:43:33 -0400 [thread overview]
Message-ID: <20030630034333.GA22830@nevyn.them.org> (raw)
Right now, CLONE_DETACHED threads silently vanish from GDB's sight when
they exit. This patch lets the thread report its exit to the debugger,
and then be auto-reaped as soon as it is collected, instead of being
reaped as soon as it exits and not reported at all.
GDB works either way, but this is more correct and will be useful for some
later GDB patches.
Please apply - thanks!
diff -Nru a/kernel/exit.c b/kernel/exit.c
--- a/kernel/exit.c Sat Jun 21 21:50:35 2003
+++ b/kernel/exit.c Sat Jun 21 21:50:35 2003
@@ -651,6 +651,8 @@
if (tsk->exit_signal != -1) {
int signal = tsk->parent == tsk->real_parent ? tsk->exit_signal : SIGCHLD;
do_notify_parent(tsk, signal);
+ } else if (tsk->ptrace) {
+ do_notify_parent(tsk, SIGCHLD);
}
tsk->state = TASK_ZOMBIE;
@@ -715,7 +717,7 @@
tsk->exit_code = code;
exit_notify(tsk);
- if (tsk->exit_signal == -1)
+ if (tsk->exit_signal == -1 && tsk->ptrace == 0)
release_task(tsk);
schedule();
@@ -859,7 +861,7 @@
BUG_ON(state != TASK_DEAD);
return 0;
}
- if (unlikely(p->exit_signal == -1))
+ if (unlikely(p->exit_signal == -1 && p->ptrace == 0))
/*
* This can only happen in a race with a ptraced thread
* dying on another processor.
@@ -889,8 +891,12 @@
/* Double-check with lock held. */
if (p->real_parent != p->parent) {
__ptrace_unlink(p);
- do_notify_parent(p, p->exit_signal);
p->state = TASK_ZOMBIE;
+ /* If this is a detached thread, this is where it goes away. */
+ if (p->exit_signal == -1)
+ release_task (p);
+ else
+ do_notify_parent(p, p->exit_signal);
p = NULL;
}
write_unlock_irq(&tasklist_lock);
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next reply other threads:[~2003-06-30 3:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-30 3:43 Daniel Jacobowitz [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-06-22 1:51 [PTRACE PATCH] Report detached thread exit to the debugger Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030630034333.GA22830@nevyn.them.org \
--to=dan@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox