From: Adrian Bunk <bunk@fs.tum.de>
To: "Robert L. Harris" <Robert.L.Harris@rdlg.net>,
Michael Chan <mchan@broadcom.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: What did I miss?
Date: Tue, 1 Jul 2003 00:36:27 +0200 [thread overview]
Message-ID: <20030630223627.GL282@fs.tum.de> (raw)
In-Reply-To: <20030630185413.GE24137@rdlg.net>
On Mon, Jun 30, 2003 at 02:54:13PM -0400, Robert L. Harris wrote:
>
> Attaching, and thanks for taking the time to poke this.
Thanks, a fix is below.
The problem is in the BCM4400 driver -ac adds. bcm4400_remove_one is
__devexit but the pointer to it didn't use __devexit_p resulting in a
.text.exit error if CONFIG_HOTPLUG is disabled.
cu
Adrian
--- drivers/net/bcm4400/b44um.c.old 2003-07-01 00:23:01.000000000 +0200
+++ drivers/net/bcm4400/b44um.c 2003-07-01 00:26:07.000000000 +0200
@@ -1019,7 +1019,7 @@
name: bcm4400_driver,
id_table: bcm4400_pci_tbl,
probe: bcm4400_init_one,
- remove: bcm4400_remove_one,
+ remove: __devexit_p(bcm4400_remove_one),
suspend: bcm4400_suspend,
resume: bcm4400_resume,
};
prev parent reply other threads:[~2003-06-30 22:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-30 16:11 What did I miss? Robert L. Harris
2003-06-30 18:47 ` Adrian Bunk
[not found] ` <20030630185413.GE24137@rdlg.net>
2003-06-30 22:36 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030630223627.GL282@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=Robert.L.Harris@rdlg.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox