What did I miss?

What did I miss?

[Robert L. Harris]

[-- Attachment #1: Type: text/plain, Size: 3103 bytes --]



2.4.21-ac3 kernel.  Compiling it without module support and alot of
devices.  I'm getting this:

gcc -D__KERNEL__
-I/exp/src1/kernels/2.4.21/Server/General/linux-2.4.21-ac3-general-SMP/include
-Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
-fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2
-march=i586   -nostdinc -iwithprefix include -DKBUILD_BASENAME=socket
-c -o socket.o socket.c
gcc -D__KERNEL__
-I/exp/src1/kernels/2.4.21/Server/General/linux-2.4.21-ac3-general-SMP/include
-Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
-fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2
-march=i586   -nostdinc -iwithprefix include
-DKBUILD_BASENAME=sysctl_net  -c -o sysctl_net.o sysctl_net.c
rm -f network.o
ld -m elf_i386  -r -o network.o socket.o core/core.o ethernet/ethernet.o
802/802.o sched/sched.o netlink/netlink.o ipv4/ipv4.o
ipv4/netfilter/netfilter.o unix/unix.o packet/packet.o bridge/bridge.o
sunrpc/sunrpc.o 8021q/8021q.o sysctl_net.o
make[2]: Leaving directory
`/exp/src1/kernels/2.4.21/Server/General/linux-2.4.21-ac3-general-SMP/net'
make[1]: Leaving directory
`/exp/src1/kernels/2.4.21/Server/General/linux-2.4.21-ac3-general-SMP/net'
ld -m elf_i386 -T
/exp/src1/kernels/2.4.21/Server/General/linux-2.4.21-ac3-general-SMP/arch/i386/vmlinux.lds
-e stext arch/i386/kernel/head.o arch/i386/kernel/init_task.o
init/main.o init/version.o init/do_mounts.o \
        --start-group \
        arch/i386/kernel/kernel.o arch/i386/mm/mm.o kernel/kernel.o
mm/mm.o fs/fs.o ipc/ipc.o \
         drivers/parport/driver.o drivers/char/char.o
drivers/block/block.o drivers/misc/misc.o drivers/net/net.o
drivers/ide/idedriver.o drivers/scsi/scsidrv.o drivers/cdrom/driver.o
drivers/pci/driver.o drivers/pnp/pnp.o drivers/video/video.o
drivers/usb/usbdrv.o drivers/media/media.o drivers/input/inputdrv.o
drivers/message/i2o/i2o.o drivers/md/mddev.o \
        net/network.o \
        /exp/src1/kernels/2.4.21/Server/General/linux-2.4.21-ac3-general-SMP/arch/i386/lib/lib.a
/exp/src1/kernels/2.4.21/Server/General/linux-2.4.21-ac3-general-SMP/lib/lib.a
/exp/src1/kernels/2.4.21/Server/General/linux-2.4.21-ac3-general-SMP/arch/i386/lib/lib.a
\
        --end-group \
        -o vmlinux
drivers/net/net.o(.data+0x854): undefined reference to `local symbols in
discarded section .text.exit'
make: *** [vmlinux] Error 1



(Please ignore CR wrapping by VI).

WTF is broken?  No obvious error messages outside a reference to net.o.
I've tried enabling and removing different options but this doesn't seem
to go away.  Any idea what option/driver is horked up?

Robert

:wq!
---------------------------------------------------------------------------
Robert L. Harris                     | GPG Key ID: E344DA3B
                                         @ x-hkp://pgp.mit.edu 
DISCLAIMER:
      These are MY OPINIONS ALONE.  I speak for no-one else.

Diagnosis: witzelsucht  	

IPv6 = robert@ipv6.rdlg.net	http://ipv6.rdlg.net
IPv4 = robert@mail.rdlg.net	http://www.rdlg.net

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: What did I miss?

[Adrian Bunk]

On Mon, Jun 30, 2003 at 12:11:12PM -0400, Robert L. Harris wrote:
> 
> 2.4.21-ac3 kernel.  Compiling it without module support and alot of
> devices.  I'm getting this:
>...
>         -o vmlinux
> drivers/net/net.o(.data+0x854): undefined reference to `local symbols in
> discarded section .text.exit'
> make: *** [vmlinux] Error 1
> 
> 
> 
> (Please ignore CR wrapping by VI).
> 
> WTF is broken?  No obvious error messages outside a reference to net.o.
> I've tried enabling and removing different options but this doesn't seem
> to go away.  Any idea what option/driver is horked up?

Please send your .config.

> Robert

TIA
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: What did I miss?

[Adrian Bunk]

On Mon, Jun 30, 2003 at 02:54:13PM -0400, Robert L. Harris wrote:
> 
> Attaching, and thanks for taking the time to poke this.

Thanks, a fix is below.

The problem is in the BCM4400 driver -ac adds. bcm4400_remove_one is 
__devexit but the pointer to it didn't use __devexit_p resulting in a
.text.exit error if CONFIG_HOTPLUG is disabled.

cu
Adrian


--- drivers/net/bcm4400/b44um.c.old	2003-07-01 00:23:01.000000000 +0200
+++ drivers/net/bcm4400/b44um.c	2003-07-01 00:26:07.000000000 +0200
@@ -1019,7 +1019,7 @@
 	name:		bcm4400_driver,
 	id_table:	bcm4400_pci_tbl,
 	probe:		bcm4400_init_one,
-	remove:		bcm4400_remove_one,
+	remove:		__devexit_p(bcm4400_remove_one),
 	suspend:	bcm4400_suspend,
 	resume:		bcm4400_resume,
 };