From: Russell King <rmk@arm.linux.org.uk>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][2.5.74] correct gcc bug comment in <linux/spinlock.h>
Date: Thu, 3 Jul 2003 17:42:04 +0100 [thread overview]
Message-ID: <20030703174204.D20336@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200307031608.h63G8B1r006911@harpo.it.uu.se>; from mikpe@csd.uu.se on Thu, Jul 03, 2003 at 06:08:11PM +0200
On Thu, Jul 03, 2003 at 06:08:11PM +0200, Mikael Pettersson wrote:
> Linus,
>
> This patch updates include/linux/spinlock.h's comment regarding gcc
> bugs for empty struct initializers, to correctly state that the bug
> is present also in 2.95.x and at least early versions of 2.96 (as
> reported by one Mandrake user).
>
> /Mikael
>
> --- linux-2.5.74/include/linux/spinlock.h.~1~ 2003-07-03 12:32:46.000000000 +0200
> +++ linux-2.5.74/include/linux/spinlock.h 2003-07-03 16:07:59.772534704 +0200
> @@ -144,7 +144,7 @@
> } while (0)
> #else
> /*
> - * gcc versions before ~2.95 have a nasty bug with empty initializers.
> + * gcc versions up to 2.95, and early versions of 2.96, have a nasty bug with empty initializers.
> */
> #if (__GNUC__ > 2)
> typedef struct { } spinlock_t;
This also isn't that clear (does it mean up to 2.95.0 but not including
2.95.1 etc.) Also, we don't build with gcc < 2.95 anyway, so there's
no need to mention anything older. This removes the doubt:
"All gcc 2.95 versions and early versions of gcc 2.96 have a nasty bug with
empty initializers."
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2003-07-03 16:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-03 16:08 [PATCH][2.5.74] correct gcc bug comment in <linux/spinlock.h> Mikael Pettersson
2003-07-03 16:42 ` Russell King [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-07-04 0:18 Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030703174204.D20336@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@csd.uu.se \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox