Re: [PATCH] Add SELinux module to 2.5.74-bk1

[Greg KH <greg@kroah.com>]

On Thu, Jul 03, 2003 at 01:51:53PM -0400, Jeff Garzik wrote:
> On Thu, Jul 03, 2003 at 01:44:55PM -0400, Stephen Smalley wrote:
> > The patch against 2.5.74-bk1 available from
> > http://www.nsa.gov/selinux/lk/2.5.74-bk1-selinux.patch.gz adds the
> > SELinux module to the tree and modifies the security/Makefile and
> > security/KConfig files for SELinux.  The last dependency for SELinux,
> > the vm_enough_memory security hook, was included in -bk1.  Please
> > consider applying.  Thanks.  diffstat output is below.  
> 
> nitpicks:
> 
> 1) "selinux" is a poor toplevel directory.  We already have the toplevel
> "security" directory, this code should go in there.

Stephen forgot to use the '-p1' flag on diffstat, the correct output is:
 security/Kconfig                                 |    2 
 security/Makefile                                |    6 
 security/selinux/Kconfig                         |   34 
 security/selinux/Makefile                        |   10 
 security/selinux/avc.c                           | 1144 +++++++
 security/selinux/hooks.c                         | 3373 +++++++++++++++++++++++
 security/selinux/include/av_inherit.h            |   37 
 security/selinux/include/av_perm_to_string.h     |  122 
 security/selinux/include/av_permissions.h        |  550 +++
 security/selinux/include/avc.h                   |  234 +
 security/selinux/include/avc_ss.h                |   81 
 security/selinux/include/class_to_string.h       |   39 
 security/selinux/include/common_perm_to_string.h |   65 
 security/selinux/include/flask.h                 |   71 
 security/selinux/include/flask_types.h           |   73 
 security/selinux/include/initial_sid_to_string.h |   32 
 security/selinux/include/objsec.h                |   87 
 security/selinux/include/security.h              |  180 +
 security/selinux/selinuxfs.c                     |  592 ++++
 security/selinux/ss/Makefile                     |   14 
 security/selinux/ss/avtab.c                      |  273 +
 security/selinux/ss/avtab.h                      |   82 
 security/selinux/ss/constraint.h                 |   62 
 security/selinux/ss/context.h                    |  131 
 security/selinux/ss/ebitmap.c                    |  344 ++
 security/selinux/ss/ebitmap.h                    |   57 
 security/selinux/ss/global.h                     |   19 
 security/selinux/ss/hashtab.c                    |  310 ++
 security/selinux/ss/hashtab.h                    |  144 
 security/selinux/ss/mls.c                        |  735 +++++
 security/selinux/ss/mls.h                        |  106 
 security/selinux/ss/mls_types.h                  |   65 
 security/selinux/ss/policydb.c                   | 1300 ++++++++
 security/selinux/ss/policydb.h                   |  274 +
 security/selinux/ss/services.c                   | 1387 +++++++++
 security/selinux/ss/services.h                   |   23 
 security/selinux/ss/sidtab.c                     |  333 ++
 security/selinux/ss/sidtab.h                     |   71 
 security/selinux/ss/symtab.c                     |   48 
 security/selinux/ss/symtab.h                     |   28 
 40 files changed, 12538 insertions(+)

That shows that everything is in the security directory.

Now to wade through 12 thousand lines of code...

greg k-h