Re: [PATCH - RFC] [1/5] 64-bit network statistics - generic net

[Jan-Benedict Glaw <jbglaw@lug-owl.de>]

[-- Attachment #1: Type: text/plain, Size: 1374 bytes --]

On Thu, 2003-07-03 22:31:27 -0400, Jeff Sipek <jeffpc@optonline.net>
wrote in message <200307032231.39842.jeffpc@optonline.net>:
Content-Description: clearsigned data
> The variables for network statistics (in struct net_device_stats) are unsigned 
> longs. On 32-bit architectures, this makes them overflow every 4GB or 2^32 
> packets. The following series of patches [against 2.5.74] makes the 
> statistics variable type configurable. The default is to leave everything the 
> way it was (unsigned long). However, when NETSTATS64 is set in the config, 
> the statistics use 64-bit variables (u_int64_t) - this works only on 32-bit 
> architectures.

Well... I don't really like to break userspace, but why don't we simply
make packet/traffic counters long long / u_int64_t? This way, we'd
simply keep almost all drivers untouched and only need to fiddle with
some sprints()/printk() statements?

Really, how many programs use the current statistics? I'd prefer to
modify them over adding strange patches like this one to the kernel...

MfG, JBG

-- 
   Jan-Benedict Glaw       jbglaw@lug-owl.de    . +49-172-7608481
   "Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg
    fuer einen Freien Staat voll Freier Bürger" | im Internet! |   im Irak!
      ret = do_actions((curr | FREE_SPEECH) & ~(IRAQ_WAR_2 | DRM | TCPA));

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]