public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: James Simmons <jsimmons@infradead.org>
Cc: vojtech@suse.cz,
	Rusty trivial patch monkey Russell  <trivial@rustcorp.com.au>,
	kernel list <linux-kernel@vger.kernel.org>
Subject: Re: Small cleanups for input
Date: Wed, 9 Jul 2003 01:14:19 +0200	[thread overview]
Message-ID: <20030708231419.GA619@elf.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.44.0307082359160.32323-100000@phoenix.infradead.org>

Hi!

> This needs to be migrated to the new power management code.

What exactly should it do? Suspend machine? Then it needs to do
equivalent of "echo 3 > /proc/acpi/sleep", but I do not think we have
generic interface for that...

Perhaps some comment should be put there?
								Pavel

> > ===================================================================
> > --- linux.orig/drivers/input/power.c	2003-06-24 11:54:39.000000000 +0200
> > +++ linux/drivers/input/power.c	2003-04-18 16:19:02.000000000 +0200
> > @@ -45,9 +45,7 @@
> >  static int suspend_button_pushed = 0;
> >  static void suspend_button_task_handler(void *data)
> >  {
> > -        //extern void pm_do_suspend(void);
> >          udelay(200); /* debounce */
> > -        //pm_do_suspend();
> >          suspend_button_pushed = 0;
> >  }
> >  
> > @@ -67,8 +65,6 @@
> >  			case KEY_SUSPEND:
> >  				printk("Powering down entire device\n");
> >  
> > -				//pm_send_all(PM_SUSPEND, dev);
> > -
> >  				if (!suspend_button_pushed) {
> >                  			suspend_button_pushed = 1;
> >                          		schedule_work(&suspend_button_task);
> > 
> > 
> 

-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]

  reply	other threads:[~2003-07-08 23:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-24 10:10 Small cleanups for input Pavel Machek
2003-07-08 22:59 ` James Simmons
2003-07-08 23:14   ` Pavel Machek [this message]
2003-07-08 23:23     ` Russell King
2003-07-08 23:32       ` Pavel Machek
2003-07-08 23:51         ` Russell King
2003-07-08 23:54           ` James Simmons
2003-07-08 23:59           ` Patrick Mochel
2003-07-08 23:50       ` James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030708231419.GA619@elf.ucw.cz \
    --to=pavel@suse.cz \
    --cc=jsimmons@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@rustcorp.com.au \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox