Re: Small cleanups for input

[Pavel Machek <pavel@suse.cz>]

Hi!

> > > This needs to be migrated to the new power management code.
> > 
> > What exactly should it do? Suspend machine? Then it needs to do
> > equivalent of "echo 3 > /proc/acpi/sleep", but I do not think we have
> > generic interface for that...
> 
> It looks like it was intended to call an old version of the suspend
> code on ARM devices - probably the power button on the iPAQ.
> 
> The correct function (in the ARM tree) is now called "suspend()" and
> deals with suspending the devices and then whatever is needed to cause
> the CPU to go into deep sleep - ie, the user visible "power off"
> state.

So perhaps we need to add machine_suspend_ram() and
machine_suspend_disk() to reboot.h? We *do* want to have some generic
interface...

> Absolutely nothing to do with swsusp I'm afraid. 8)

That's okay, I'm doing suspend-to-RAM, too.
								Pavel

> > > > ===================================================================
> > > > --- linux.orig/drivers/input/power.c	2003-06-24 11:54:39.000000000 +0200
> > > > +++ linux/drivers/input/power.c	2003-04-18 16:19:02.000000000 +0200
> > > > @@ -45,9 +45,7 @@
> > > >  static int suspend_button_pushed = 0;
> > > >  static void suspend_button_task_handler(void *data)
> > > >  {
> > > > -        //extern void pm_do_suspend(void);
> > > >          udelay(200); /* debounce */
> > > > -        //pm_do_suspend();
> > > >          suspend_button_pushed = 0;
> > > >  }
> 

-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]