RE: CRIS architecture update

RE: CRIS architecture update

[Mikael Starvik]

Ok, do you have any other suggestion on how to make the driver 
compilable for both >= 2.4.20 and < 2.4.20?

/Mikael

-----Original Message-----
From: linux-kernel-owner@vger.kernel.org
[mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of Greg KH
Sent: Wednesday, July 09, 2003 10:15 PM
To: Linux Kernel Mailing List
Subject: Re: CRIS architecture update


> diff -Nru a/arch/cris/drivers/usb-host.c b/arch/cris/drivers/usb-host.c
> --- a/arch/cris/drivers/usb-host.c	Wed Jul  9 12:06:00 2003
> +++ b/arch/cris/drivers/usb-host.c	Wed Jul  9 12:06:00 2003
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION (2, 4, 20)
> +typedef struct urb urb_t, *purb_t;
> +typedef struct iso_packet_descriptor iso_packet_descriptor_t; typedef 
> +struct usb_ctrlrequest devrequest; #endif

ICK ICK ICK!  Please do not do this.  These typedefs were removed for a
reason!

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: CRIS architecture update

[Greg KH]

On Thu, Jul 10, 2003 at 07:24:58AM +0200, Mikael Starvik wrote:
> Ok, do you have any other suggestion on how to make the driver 
> compilable for both >= 2.4.20 and < 2.4.20?

As the driver is _in_ the kernel tree, why does it need to be compilable
for older kernels?  :)

Anyway, yes, just use the structure name, not the typedef.  That is
backwards compatible.

For example, don't use "urb_t" but instead, "struct urb".

Hm, I think I did actually change one of the structure names, but I
don't think you use that structure in the host controller.

Hope this helps,

greg k-h

Re: CRIS architecture update

[Greg KH]

On Thu, Jul 10, 2003 at 10:13:41AM -0700, Greg KH wrote:
> On Thu, Jul 10, 2003 at 07:24:58AM +0200, Mikael Starvik wrote:
> > Ok, do you have any other suggestion on how to make the driver 
> > compilable for both >= 2.4.20 and < 2.4.20?
> 
> As the driver is _in_ the kernel tree, why does it need to be compilable
> for older kernels?  :)

Speaking of older kernels, any chances for a 2.5 update?  I know the
CRIS USB host controller driver has fallen pretty out of date with the
rest of the USB core, and would hope to see that sync up sometime.

thanks,

greg k-h

RE: CRIS architecture update

[Mikael Starvik]

>As the driver is _in_ the kernel tree, why does it need to be compilable
>for older kernels?  :)

We have several customers running 2.4.17 or 2.4.19 that are happy with
these releases but needs the latest USB host controller bug fixes. It
 is probably not too hard to convince them to use 2.4.20 or newer.

/Mikael

RE: CRIS architecture update

[Mikael Starvik]

>Speaking of older kernels, any chances for a 2.5 update? 

Yes. I have sent patches to Linus several times, the latest one today.
So far he has been dropping my patches on the floor.

So far our 2.5 tree doesn't have a USB driver because I 
would like to wait until the USB framework is less volatile.
In my mind we will port the USB driver somewhere around
2.6.0.

/Mikael

-----Original Message-----
From: Greg KH [mailto:greg@kroah.com]
Sent: Thursday, July 10, 2003 7:15 PM
To: Mikael Starvik
Cc: 'Linux Kernel Mailing List'
Subject: Re: CRIS architecture update


On Thu, Jul 10, 2003 at 10:13:41AM -0700, Greg KH wrote:
> On Thu, Jul 10, 2003 at 07:24:58AM +0200, Mikael Starvik wrote:
> > Ok, do you have any other suggestion on how to make the driver 
> > compilable for both >= 2.4.20 and < 2.4.20?
> 
> As the driver is _in_ the kernel tree, why does it need to be compilable
> for older kernels?  :)

Speaking of older kernels, any chances for a 2.5 update?  I know the
CRIS USB host controller driver has fallen pretty out of date with the
rest of the USB core, and would hope to see that sync up sometime.

thanks,

greg k-h

Re: CRIS architecture update

[Greg KH]

On Thu, Jul 10, 2003 at 10:24:56PM +0200, Mikael Starvik wrote:
> >Speaking of older kernels, any chances for a 2.5 update? 
> 
> Yes. I have sent patches to Linus several times, the latest one today.
> So far he has been dropping my patches on the floor.
> 
> So far our 2.5 tree doesn't have a USB driver because I 
> would like to wait until the USB framework is less volatile.

Heh, like that will ever happen... :)

But any api changes that are made to USB are also made to all in-kernel
drivers.  I've been skipping the CRIS USB driver since way back in early
2.5 you told me too.

> In my mind we will port the USB driver somewhere around
> 2.6.0.

Glad to hear it.

thanks,

greg k-h

Re: CRIS architecture update

[Greg KH]

> diff -Nru a/arch/cris/drivers/usb-host.c b/arch/cris/drivers/usb-host.c
> --- a/arch/cris/drivers/usb-host.c	Wed Jul  9 12:06:00 2003
> +++ b/arch/cris/drivers/usb-host.c	Wed Jul  9 12:06:00 2003
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION (2, 4, 20)
> +typedef struct urb urb_t, *purb_t;
> +typedef struct iso_packet_descriptor iso_packet_descriptor_t;
> +typedef struct usb_ctrlrequest devrequest;
> +#endif

ICK ICK ICK!  Please do not do this.  These typedefs were removed for a
reason!

greg k-h