From: "David S. Miller" <davem@redhat.com>
To: Pekka Pietikainen <pp@netppl.fi>
Cc: linux-kernel@vger.kernel.org, jgarzik@pobox.com
Subject: Re: REQ: BCM4400 network driver for 2.4.22
Date: Fri, 11 Jul 2003 20:24:26 -0700 [thread overview]
Message-ID: <20030711202426.5b0e475b.davem@redhat.com> (raw)
In-Reply-To: <20030711163345.GA23076@netppl.fi>
On Fri, 11 Jul 2003 19:33:45 +0300
Pekka Pietikainen <pp@netppl.fi> wrote:
> @@ -660,9 +671,12 @@
> ctrl = src_desc->ctrl;
> if (dest_idx == (B44_RX_RING_SIZE - 1))
> ctrl |= cpu_to_le32(DESC_CTRL_EOT);
> + else
> + ctrl &= ~DESC_CTRL_EOT;
Please be kind to us underprivileged big-endian users
out here :-)
- ctrl &= ~DESC_CTRL_EOT;
+ ctrl &= cpu_to_le32(~DESC_CTRL_EOT);
> @@ -733,6 +749,7 @@
> /* DMA sync done above */
> memcpy(copy_skb->data, skb->data, len);
>
> + skb->data-=bp->rx_offset;
> skb = copy_skb;
> }
> skb->ip_summed = CHECKSUM_NONE;
You can't modify skb->data without doing something sane
with skb->len and friends too, this is why we have skb_*()
interfaces to do these kinds of operations which do all
the necessary book-keeping :-)
Otherwise looks good.
next prev parent reply other threads:[~2003-07-12 3:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-09 21:34 REQ: BCM4400 network driver for 2.4.22 Bas Mevissen
2003-07-09 22:05 ` Jeff Garzik
2003-07-11 16:33 ` Pekka Pietikainen
2003-07-11 16:58 ` Jeff Garzik
2003-07-11 20:04 ` Pekka Pietikainen
2003-07-12 3:24 ` David S. Miller [this message]
2003-07-14 20:12 ` Pekka Pietikainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030711202426.5b0e475b.davem@redhat.com \
--to=davem@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pp@netppl.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox